cc: Added modifier string to clarify perf tests.

cc/resources/raster_worker_pool_perftest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/raster_worker_pool.h"
 
 #include "base/time/time.h"
 #include "cc/resources/image_raster_worker_pool.h"
 #include "cc/resources/pixel_buffer_raster_worker_pool.h"
 #include "cc/resources/resource_provider.h"
@@ skipping 238 matching lines @@
       raster_worker_pool_->ScheduleTasks(&tasks);
       raster_worker_pool_->CheckForCompletedTasks();
       timer_.NextLap();
     } while (!timer_.HasTimeLimitExpired());
 
     RasterWorkerPool::RasterTask::Queue empty;
     raster_worker_pool_->ScheduleTasks(&empty);
     raster_worker_pool_->CheckForCompletedTasks();
 
     perf_test::PrintResult("schedule_tasks",
-                           "",
+                           TestModifierString(),
                            test_name,
                            timer_.LapsPerSecond(),
                            "runs/s",
                            true);
   }
 
   void RunScheduleAlternateTasksTest(const std::string& test_name,
                                      unsigned num_raster_tasks,
                                      unsigned num_image_decode_tasks) {
     const size_t kNumVersions = 2;
@@ skipping 17 matching lines @@
       raster_worker_pool_->CheckForCompletedTasks();
       ++count;
       timer_.NextLap();
     } while (!timer_.HasTimeLimitExpired());
 
     RasterWorkerPool::RasterTask::Queue empty;
     raster_worker_pool_->ScheduleTasks(&empty);
     raster_worker_pool_->CheckForCompletedTasks();
 
     perf_test::PrintResult("schedule_alternate_tasks",
-                           "",
+                           TestModifierString(),
                            test_name,
                            timer_.LapsPerSecond(),
                            "runs/s",
                            true);
   }
 
   void RunScheduleAndExecuteTasksTest(const std::string& test_name,
                                       unsigned num_raster_tasks,
                                       unsigned num_image_decode_tasks) {
     Task::Vector image_decode_tasks;
@@ skipping 13 matching lines @@
         continue;
       raster_worker_pool_->CheckForCompletedTasks();
       timer_.NextLap();
     } while (!timer_.HasTimeLimitExpired());
 
     RasterWorkerPool::RasterTask::Queue empty;
     raster_worker_pool_->ScheduleTasks(&empty);
     raster_worker_pool_->CheckForCompletedTasks();
 
     perf_test::PrintResult("schedule_and_execute_tasks",
-                           "",
+                           TestModifierString(),
                            test_name,
                            timer_.LapsPerSecond(),
                            "runs/s",
                            true);
   }
 
  private:
+  std::string TestModifierString() const {
+    switch (GetParam()) {
+      case RASTER_WORKER_POOL_TYPE_PIXEL_BUFFER:
+        return std::string("_pixel_raster_worker_pool");
+      case RASTER_WORKER_POOL_TYPE_IMAGE:
+        return std::string("_image_raster_worker_pool");
+      default:

[reveman, 2014/02/14 23:40:16]

Please remove this "default:" case and move NOTREACHED() below so the compiler
will complain if we add a new type but fail to update this function.

[alokp, 2014/02/15 00:26:11]

Done.

+        NOTREACHED();
+    }
+    return std::string();
+  }
+
   scoped_refptr<TestContextProvider> context_provider_;
   FakeOutputSurfaceClient output_surface_client_;
   scoped_ptr<FakeOutputSurface> output_surface_;
   scoped_ptr<ResourceProvider> resource_provider_;
   scoped_ptr<internal::TaskGraphRunner> task_graph_runner_;
   scoped_ptr<RasterWorkerPool> raster_worker_pool_;
   std::vector<RasterWorkerPool::RasterTask> tasks_;
   LapTimer timer_;
 };
 
@@ skipping 24 matching lines @@
   RunScheduleAndExecuteTasksTest("32_4", 32, 4);
 }
 
 INSTANTIATE_TEST_CASE_P(RasterWorkerPoolPerfTests,
                         RasterWorkerPoolPerfTest,
                         ::testing::Values(RASTER_WORKER_POOL_TYPE_PIXEL_BUFFER,
                                           RASTER_WORKER_POOL_TYPE_IMAGE));
 
 }  // namespace
 }  // namespace cc