Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1677423002: Revert "Fix super noSuchMethod handling." (Closed)

Created:
4 years, 10 months ago by Johnni Winther
Modified:
4 years, 10 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Fix super noSuchMethod handling." This reverts commit 756d95a372b5123193644f07b65b93c106a92078. BUG= Committed: https://github.com/dart-lang/sdk/commit/a0d7b64fdefbd5e05b9ce7e80d7883f61a99102e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -418 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 17 chunks +20 lines, -35 lines 0 comments Download
M pkg/compiler/lib/src/info/send_info.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 9 chunks +13 lines, -34 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 chunk +0 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 3 chunks +0 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 chunk +1 line, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +1 line, -13 lines 0 comments Download
M tests/compiler/dart2js/no_such_method_enabled_test.dart View 13 chunks +123 lines, -114 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_visitor.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/issue_25671a_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D tests/language/issue_25671b_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download
D tests/language/super_no_such_method1_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/language/super_no_such_method2_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/language/super_no_such_method3_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D tests/language/super_no_such_method4_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/language/super_no_such_method5_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
TBR
4 years, 10 months ago (2016-02-09 12:02:05 UTC) #2
asgerf
lgtm :(
4 years, 10 months ago (2016-02-09 12:02:35 UTC) #3
Johnni Winther
4 years, 10 months ago (2016-02-09 12:02:43 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a0d7b64fdefbd5e05b9ce7e80d7883f61a99102e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698