Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1677423002: Revert "Fix super noSuchMethod handling." (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index f7fa80a4b01c4e59c86f18634a89d83780a870b7..8766af3ff025653eb3c19aba6697b836eccb908c 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -4553,10 +4553,7 @@ class SsaBuilder extends ast.Visitor
String name = selector.name;
ClassElement cls = currentNonClosureClass;
- MethodElement element = cls.lookupSuperMember(Identifiers.noSuchMethod_);
- if (!Selectors.noSuchMethod_.signatureApplies(element)) {
- element = coreClasses.objectClass.lookupMember(Identifiers.noSuchMethod_);
- }
+ Element element = cls.lookupSuperMember(Identifiers.noSuchMethod_);
if (compiler.enabledInvokeOn && !element.enclosingClass.isObject) {
// Register the call as dynamic if [noSuchMethod] on the super
// class is _not_ the default implementation from [Object], in
@@ -4696,15 +4693,6 @@ class SsaBuilder extends ast.Visitor
}
@override
- void visitUnresolvedSuperSet(
- ast.Send node,
- Element element,
- ast.Node rhs,
- _) {
- handleUnresolvedSuperInvoke(node);
- }
-
- @override
void visitSuperSetterGet(
ast.Send node,
MethodElement setter,
« no previous file with comments | « pkg/compiler/lib/src/resolution/send_structure.dart ('k') | tests/compiler/dart2js/no_such_method_enabled_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698