third_party/WebKit/Source/wtf/dtoa/utils.h - Issue 1677363002: Change assert to release assert for WTF::double_conversion::Vector to prevent OOB memory access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/dtoa/utils.h

Issue 1677363002: Change assert to release assert for WTF::double_conversion::Vector to prevent OOB memory access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/wtf/dtoa/utils.h

diff --git a/third_party/WebKit/Source/wtf/dtoa/utils.h b/third_party/WebKit/Source/wtf/dtoa/utils.h

index 0a61c0155f74a499171e44c9fc35008e4f5b7b4b..2f9073631ee8d90143ef7a8db9db34f3e466580b 100644

--- a/third_party/WebKit/Source/wtf/dtoa/utils.h

+++ b/third_party/WebKit/Source/wtf/dtoa/utils.h

@@ -165,7 +165,7 @@ namespace double_conversion {

// Access individual vector elements - checks bounds in debug mode.

inferno 2016/02/09 04:30:12 Please fix the comment.

mmoroz 2016/02/09 16:50:55 Done.

T& operator[](int index) const {

- ASSERT(0 <= index && index < length_);

+ RELEASE_ASSERT(0 <= index && index < length_);

return start_[index];

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »