Compute ElementImpl.hashCode using location.

Compute ElementImpl.hashCode using location.

We need this to ensure that Impl and Handle have the same hash.

This reduces number of shared test failures from 267 to 67 when using
SDK summaries.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/20d31ea8c3ef7e40aa606b6776d51b4a557a6ace

[Brian Wilkerson, 2016-02-09 14:18:16]

LGTM

[Paul Berry, 2016-02-09 14:49:26]

lgtm

[scheglov, 2016-02-09 15:06:26]

Description was changed from

==========
Compute ElementImpl.hashCode using location.

We need this to ensure that Impl and Handle have the same hash.

This reduces number of shared test failures from 267 to 67 when using
SDK summaries.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Compute ElementImpl.hashCode using location.

We need this to ensure that Impl and Handle have the same hash.

This reduces number of shared test failures from 267 to 67 when using
SDK summaries.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/20d31ea8c3ef7e40aa606b6776d51b4a557a6ace
==========

[scheglov, 2016-02-09 15:06:27]

Committed patchset #1 (id:1) manually as
20d31ea8c3ef7e40aa606b6776d51b4a557a6ace (presubmit successful).

[Paul Berry, 2016-02-09 16:25:28]

On 2016/02/09 15:06:27, scheglov wrote:
> Committed patchset #1 (id:1) manually as
> 20d31ea8c3ef7e40aa606b6776d51b4a557a6ace (presubmit successful).

It looks like this caused a test failure.  Repro with: python tools/test.py
-aia32 --checked -mrelease -t60 pkg/analyzer/test/src/dart/element/element_test

Sample failure:
ERROR: LibraryElementImplTest | test_getPrefixes
  Test failed: Caught UnsupportedOperationException: /l1.dart does not exist.
null
  package:analyzer/src/generated/source.dart 383:5             
NonExistingSource.encoding
  package:analyzer/src/dart/element/element.dart 3116:60       
LibraryElementImpl.identifier
  package:analyzer/src/dart/element/element.dart 2086:54       
ElementLocationImpl.ElementLocationImpl.con1
  package:analyzer/src/dart/element/element.dart 1860:29       
ElementImpl.location
  package:analyzer/src/dart/element/element.dart 1804:25       
ElementImpl.hashCode
  dart:collection-patch/collection_patch.dart 562              
_HashSet._hashCode
  dart:collection-patch/collection_patch.dart 598               _HashSet.add
  package:analyzer/src/dart/element/element.dart 3287:18       
LibraryElementImpl.prefixes
  pkg/analyzer/test/src/dart/element/element_test.dart 3502:44 
LibraryElementImplTest.test_getPrefixes
  dart:mirrors-patch/mirrors_impl.dart 533                     
_LocalInstanceMirror._invoke
  dart:mirrors-patch/mirrors_impl.dart 529                     
_LocalInstanceMirror.invoke
  pkg/analyzer/test/reflective_tests.dart 106:35                _runTest.<fn>
  dart:async/zone.dart 902                                      _rootRunUnary
  dart:async/zone.dart 798                                     
_CustomZone.runUnary
  dart:async/future_impl.dart 551                              
_Future._propagateToListeners.handleValueCallback
  dart:async/future_impl.dart 637                              
_Future._propagateToListeners
  dart:async/future_impl.dart 424                              
_Future._completeWithValue
  dart:async/future_impl.dart 479                              
_Future._asyncComplete.<fn>
  dart:async/zone.dart 895                                      _rootRun
  dart:async/zone.dart 790                                      _CustomZone.run
  dart:async/zone.dart 696                                     
_CustomZone.runGuarded
  dart:async/zone.dart 721                                     
_CustomZone.bindCallback.<fn>
  dart:async/schedule_microtask.dart 41                         _microtaskLoop
  dart:async/schedule_microtask.dart 50                        
_startMicrotaskLoop
  dart:isolate-patch/timer_impl.dart 394                       
_Timer._runTimers
  dart:isolate-patch/timer_impl.dart 414                       
_Timer._handleMessage
  dart:isolate-patch/isolate_patch.dart 148                    
_RawReceivePortImpl._handleMessage

[scheglov, 2016-02-09 16:38:04]

On 2016/02/09 16:25:28, Paul Berry wrote:
> On 2016/02/09 15:06:27, scheglov wrote:
> > Committed patchset #1 (id:1) manually as
> > 20d31ea8c3ef7e40aa606b6776d51b4a557a6ace (presubmit successful).
> 
> It looks like this caused a test failure.  Repro with: python tools/test.py
> -aia32 --checked -mrelease -t60
pkg/analyzer/test/src/dart/element/element_test
> 

  You're right.
  One of the test suites for missing.
  https://codereview.chromium.org/1681153002