Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1681153002: Include dart/test_all into src/test_all and fix element tests. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pkg/analyzer/lib/src/generated/source.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/test/src/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 10 months ago (2016-02-09 16:37:16 UTC) #1
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-09 16:40:48 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 854890836c72297a6fa97ff883c40255c60b8b96 (presubmit successful).
4 years, 10 months ago (2016-02-09 16:41:31 UTC) #4
Paul Berry
4 years, 10 months ago (2016-02-09 16:46:23 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698