Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 167713003: Remove allow-webui-compositing switch (Closed)

Created:
6 years, 10 months ago by jamesr
Modified:
6 years, 10 months ago
Reviewers:
sky, piman
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, jam, chrome-speed-team+watch_google.com, darin-cc_chromium.org, oshima+watch_chromium.org, joi+watch-content_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Remove allow-webui-compositing switch Long ago, we used to disable compositing on chrome: and about: URLs by default since that caused a startup performance hit. We then had an --allow-webui-compositing switch to override this behavior when desired. The usefulness of this behavior has long gone and we completely ignore the behavior and the flag on aura builds. This nukes it from the code Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/perf/frame_rate/frame_rate_tests.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/android/content_startup_flags.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jamesr
This will be a very minor behavior change for mac as the flag is ignored ...
6 years, 10 months ago (2014-02-14 23:29:14 UTC) #1
piman
lgtm
6 years, 10 months ago (2014-02-14 23:31:29 UTC) #2
sky
LGTM
6 years, 10 months ago (2014-02-18 16:25:50 UTC) #3
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 10 months ago (2014-02-18 16:29:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/167713003/1
6 years, 10 months ago (2014-02-18 16:29:41 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 17:56:18 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=265640
6 years, 10 months ago (2014-02-18 17:56:18 UTC) #7
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 10 months ago (2014-02-18 22:39:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/167713003/1
6 years, 10 months ago (2014-02-18 22:39:16 UTC) #9
jamesr
The CQ bit was unchecked by jamesr@chromium.org
6 years, 10 months ago (2014-02-18 23:32:36 UTC) #10
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 10 months ago (2014-02-18 23:32:38 UTC) #11
jamesr
On 2014/02/18 23:32:38, jamesr wrote: > The CQ bit was checked by mailto:jamesr@chromium.org Argh, focus ...
6 years, 10 months ago (2014-02-18 23:33:10 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 01:56:01 UTC) #13
Message was sent while issue was closed.
Change committed as 251915

Powered by Google App Engine
This is Rietveld 408576698