Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6539)

Unified Diff: chrome/browser/android/ntp_snippets_controller.h

Issue 1677073002: Fetch snippets from ChromeReader and show them on the NTP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/ntp_snippets_controller.h
diff --git a/chrome/browser/android/ntp_snippets_controller.h b/chrome/browser/android/ntp_snippets_controller.h
new file mode 100644
index 0000000000000000000000000000000000000000..a798ed8b90d0df2f3f097c126028248cb57595a4
--- /dev/null
+++ b/chrome/browser/android/ntp_snippets_controller.h
@@ -0,0 +1,29 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_ANDROID_NTP_SNIPPETS_CONTROLLER_H_
+#define CHROME_BROWSER_ANDROID_NTP_SNIPPETS_CONTROLLER_H_
+
+#include <jni.h>
+
+#include "base/android/scoped_java_ref.h"
+
+using base::android::JavaParamRef;
Marc Treib 2016/02/10 10:44:43 Here too: No "using" in headers
May 2016/02/10 18:16:47 Done.
+
+// The C++ counterpart to SnippetsController.java. Enables Java code to fetch
+// snippets from the server
+class NTPSnippetsController {
+ public:
+ NTPSnippetsController();
+ void Destroy(JNIEnv* env, const JavaParamRef<jobject>& obj);
+
+ static bool RegisterNTPSnippetsController(JNIEnv* env);
Marc Treib 2016/02/10 10:44:43 Here too: Simply "Register" is enough IMO
May 2016/02/10 18:16:47 Done.
+
+ private:
+ ~NTPSnippetsController();
+
+ DISALLOW_COPY_AND_ASSIGN(NTPSnippetsController);
+};
+
+#endif // CHROME_BROWSER_ANDROID_NTP_SNIPPETS_CONTROLLER_H_

Powered by Google App Engine
This is Rietveld 408576698