Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Side by Side Diff: chrome/browser/android/ntp_snippets_controller.h

Issue 1677073002: Fetch snippets from ChromeReader and show them on the NTP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_ANDROID_NTP_SNIPPETS_CONTROLLER_H_
6 #define CHROME_BROWSER_ANDROID_NTP_SNIPPETS_CONTROLLER_H_
7
8 #include <jni.h>
9
10 #include "base/android/scoped_java_ref.h"
11
12 using base::android::JavaParamRef;
Marc Treib 2016/02/10 10:44:43 Here too: No "using" in headers
May 2016/02/10 18:16:47 Done.
13
14 // The C++ counterpart to SnippetsController.java. Enables Java code to fetch
15 // snippets from the server
16 class NTPSnippetsController {
17 public:
18 NTPSnippetsController();
19 void Destroy(JNIEnv* env, const JavaParamRef<jobject>& obj);
20
21 static bool RegisterNTPSnippetsController(JNIEnv* env);
Marc Treib 2016/02/10 10:44:43 Here too: Simply "Register" is enough IMO
May 2016/02/10 18:16:47 Done.
22
23 private:
24 ~NTPSnippetsController();
25
26 DISALLOW_COPY_AND_ASSIGN(NTPSnippetsController);
27 };
28
29 #endif // CHROME_BROWSER_ANDROID_NTP_SNIPPETS_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698