chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java - Issue 1677073002: Fetch snippets from ChromeReader and show them on the NTP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 1677073002: Fetch snippets from ChromeReader and show them on the NTP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

index 072c320f3fd641095a90cd02caf10d3590fbb081..805da378d630925258cfa4a3c0f872d01a2a1a84 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

@@ -87,7 +87,6 @@ public class NewTabPageView extends FrameLayout

private NewTabPageManager mManager;

private MostVisitedDesign mMostVisitedDesign;

private MostVisitedItem[] mMostVisitedItems;

- private SnippetsManager mSnippetsManager;

private boolean mFirstShow = true;

private boolean mSearchProviderHasLogo = true;

private boolean mHasReceivedMostVisitedSites;

@@ -250,7 +249,7 @@ public class NewTabPageView extends FrameLayout

* @param searchProviderHasLogo Whether the search provider has a logo.

public void initialize(NewTabPageManager manager, boolean isSingleUrlBarMode,

- boolean searchProviderHasLogo) {

+ boolean searchProviderHasLogo, SnippetsManager snippetsManager) {

mManager = manager;

mScrollView = (NewTabScrollView) findViewById(R.id.ntp_scrollview);

@@ -340,7 +339,6 @@ public class NewTabPageView extends FrameLayout

RecordHistogram.recordEnumeratedHistogram(SnippetsManager.SNIPPETS_STATE_HISTOGRAM,

SnippetsManager.SNIPPETS_SHOWN, SnippetsManager.NUM_SNIPPETS_ACTIONS);

mSnippetsView.setLayoutManager(new LinearLayoutManager(getContext()));

- mSnippetsManager = new SnippetsManager(mManager, mSnippetsView);

mSnippetsView.addOnScrollListener(new RecyclerView.OnScrollListener() {

private boolean mScrolledOnce = false;

@Override

@@ -355,6 +353,7 @@ public class NewTabPageView extends FrameLayout

SnippetsManager.NUM_SNIPPETS_ACTIONS);

}

});

+ snippetsManager.setSnippetsView(mSnippetsView);

}

// Set up interests