Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 1677073002: Fetch snippets from ChromeReader and show them on the NTP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 876517020d8d4fb9bd362ad1d46ff8914408a664..f89cc49344739c5941fa8dc1ca5aa85b2a70365b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -47,6 +47,7 @@ import org.chromium.chrome.browser.ntp.LogoBridge.LogoObserver;
import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
import org.chromium.chrome.browser.ntp.interests.InterestsPage;
import org.chromium.chrome.browser.ntp.interests.InterestsPage.InterestsClickListener;
+import org.chromium.chrome.browser.ntp.snippets.SnippetsManager;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;
import org.chromium.chrome.browser.preferences.DocumentModeManager;
@@ -120,6 +121,7 @@ public class NewTabPage
private String mAnimatedLogoUrl;
private FakeboxDelegate mFakeboxDelegate;
private OfflinePageBridge mOfflinePageBridge;
+ private SnippetsManager mSnippetsManager;
// The timestamp at which the constructor was called.
private final long mConstructedTimeNs;
@@ -576,10 +578,12 @@ public class NewTabPage
mLogoBridge = new LogoBridge(mProfile);
updateSearchProviderHasLogo();
+ mSnippetsManager = new SnippetsManager(mNewTabPageManager, mProfile);
+
LayoutInflater inflater = LayoutInflater.from(activity);
mNewTabPageView = (NewTabPageView) inflater.inflate(R.layout.new_tab_page, null);
mNewTabPageView.initialize(mNewTabPageManager, isInSingleUrlBarMode(activity),
- mSearchProviderHasLogo);
+ mSearchProviderHasLogo, mSnippetsManager);
mIsTablet = DeviceFormFactor.isTablet(activity);
@@ -761,6 +765,10 @@ public class NewTabPage
mLogoBridge.destroy();
mLogoBridge = null;
}
+ if (mSnippetsManager != null) {
+ mSnippetsManager.destroy();
+ mSnippetsManager = null;
+ }
if (mMostVisitedItemRemovedController != null) {
mTab.getSnackbarManager().dismissSnackbars(mMostVisitedItemRemovedController);
}

Powered by Google App Engine
This is Rietveld 408576698