Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 167703002: Exclude Translate Bubble strings from non Views builds. (Closed)

Created:
6 years, 10 months ago by aurimas (slooooooooow)
Modified:
6 years, 10 months ago
Reviewers:
hajimehoshi
CC:
chromium-reviews
Visibility:
Public.

Description

Exclude Translate Bubble strings from non Views builds. BUG=326023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251897

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -45 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +47 lines, -45 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
aurimas (slooooooooow)
Hey Hajime, Please take a look at this change. Thanks, Aurimas
6 years, 10 months ago (2014-02-14 23:02:41 UTC) #1
hajimehoshi
lgtm > Exclude Password Bubble strings from non Views builds. Translate bubble, right?
6 years, 10 months ago (2014-02-15 05:45:48 UTC) #2
aurimas (slooooooooow)
On 2014/02/15 05:45:48, hajimehoshi wrote: > lgtm > > > Exclude Password Bubble strings from ...
6 years, 10 months ago (2014-02-18 17:23:29 UTC) #3
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 10 months ago (2014-02-18 17:23:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/167703002/1
6 years, 10 months ago (2014-02-18 17:23:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/167703002/1
6 years, 10 months ago (2014-02-18 18:22:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/167703002/1
6 years, 10 months ago (2014-02-18 18:30:18 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 18:46:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-18 18:46:22 UTC) #9
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 10 months ago (2014-02-18 18:50:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/167703002/1
6 years, 10 months ago (2014-02-18 18:51:21 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 18:51:57 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-18 18:51:58 UTC) #13
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 10 months ago (2014-02-18 22:12:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/167703002/1
6 years, 10 months ago (2014-02-18 22:13:44 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 00:29:07 UTC) #16
Message was sent while issue was closed. 
Change committed as 251897

Powered by Google App Engine
This is Rietveld 408576698