Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1676893002: fix float <---> uint16_t conversion, with Mike's tests. (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix float <---> uint16_t conversion, with Mike's tests. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1679713002 patch from issue 1679713002 at patchset 1 (http://crrev.com/1679713002#ps1) CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/629f25a7ef229d97e22530eae043882b20cd8d8c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1 line) Patch
M src/opts/SkNx_sse.h View 1 chunk +10 lines, -1 line 0 comments Download
M tests/SkNxTest.cpp View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
mtklein_C
4 years, 10 months ago (2016-02-07 21:10:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676893002/1
4 years, 10 months ago (2016-02-07 21:10:08 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-07 21:10:09 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
4 years, 10 months ago (2016-02-08 03:10:00 UTC) #8
reed1
lgtm
4 years, 10 months ago (2016-02-08 13:53:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676893002/1
4 years, 10 months ago (2016-02-08 13:54:03 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 13:54:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/629f25a7ef229d97e22530eae043882b20cd8d8c

Powered by Google App Engine
This is Rietveld 408576698