Issue 167683004: Fixes for MemoryCacheHTTPServerTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 167683004: Fixes for MemoryCacheHTTPServerTest. (Closed)

Created:
6 years, 10 months ago by achuithb

Modified:
6 years, 10 months ago

Reviewers:
dtu, tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@navigate

Visibility:
Public.

More Reviews

Description

Fixes for MemoryCacheHTTPServerTest. Make this a TabTestCase since it's the only one using navigate_test explicitly. Remove navigate_test and inline this code in TabTestCase.Navigate. BUG=337582 TEST=manual, trybot Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252525

Patch Set 1 #

Patch Set 2 : rebase #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -66 lines)			Patch
M	tools/telemetry/telemetry/core/memory_cache_http_server_unittest.py	View		2 chunks	+34 lines, -43 lines	0 comments	Download
D	tools/telemetry/telemetry/unittest/navigate_test.py	View		1 chunk	+0 lines, -20 lines	0 comments	Download
M	tools/telemetry/telemetry/unittest/tab_test_case.py	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

achuithb

This fixes the last holdout, and also fixes a bug I introduced with the last ...

6 years, 10 months ago (2014-02-20 20:57:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/167683004/30001

6 years, 10 months ago (2014-02-20 21:05:58 UTC) #4

Message was sent while issue was closed.

Change committed as 252525

Expand Messages | Collapse Messages