Simplify type argument instantiation cache lookup by introducing an array

Simplify type argument instantiation cache lookup by introducing an array
of 1 zero Smi.

Was replaced by https://codereview.chromium.org//169223005

[Florian Schneider, 2014-02-17 10:09:58]

LGTM.

https://codereview.chromium.org/167683002/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/167683002/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_ia32.cc:2199: __ addl(EDI, Immediate(2 *
kWordSize));
You could save one branch instruction by reordering the code like this:

__ addl(EDI, Immediate(2 * kWordSize));
__ cmpl(EDX, Immediate(Smi::RawValue(StubCode::kNoInstantiator)));
__ j(NOT_EQUAL, &loop);


This should work on all platforms.

https://codereview.chromium.org/167683002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/167683002/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:4297: ASSERT(StubCode::kNoInstantiator == 0);
That can be make a COMPILE_ASSERT.

[regis, 2014-02-18 19:29:29]

Thanks!

https://codereview.chromium.org/167683002/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/167683002/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language_ia32.cc:2199: __ addl(EDI, Immediate(2 *
kWordSize));
On 2014/02/17 10:09:59, Florian Schneider wrote:
> You could save one branch instruction by reordering the code like this:
> 
> __ addl(EDI, Immediate(2 * kWordSize));
> __ cmpl(EDX, Immediate(Smi::RawValue(StubCode::kNoInstantiator)));
> __ j(NOT_EQUAL, &loop);
> 
> 
> This should work on all platforms.

Done on all platforms.

https://codereview.chromium.org/167683002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/167683002/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:4297: ASSERT(StubCode::kNoInstantiator == 0);
On 2014/02/17 10:09:59, Florian Schneider wrote:
> That can be make a COMPILE_ASSERT.

I had never noticed this assert flavor before. Done.

[regis, 2017-09-29 17:12:13]

Description was changed from

==========
Simplify type argument instantiation cache lookup by introducing an array
of 1 zero Smi.
==========

to

==========
Simplify type argument instantiation cache lookup by introducing an array
of 1 zero Smi.

Was replaced by https://codereview.chromium.org//169223005
==========