Show elided hostnames in modal dialog titles

Show elided hostnames in modal dialog titles

Long domain names can embiggen alert() dialogs beyond the limits. To prevent
that, show elided hostnames instead of security origin. Dialog title for file://,
filesystem:// and other nonstandard URLs (data:, blob: etc) is displayed as
"This page says" instead. Android already elides the dialog title, although in the
other direction.

BUG=584759
Committed: https://crrev.com/5b6d71ddab30d1ce2fcb355c1c2e41d4218594c1
Cr-Commit-Position: refs/heads/master@{#374187}

[meacer, 2016-02-05 21:36:59]

Description was changed from

==========
Elide urls in modal dialog titles

BUG=584759
==========

to

==========
Long domain names can embiggen alert() dialogs beyond the limits. To prevent
that, show elided hostnames instead of security origin. Dialog title for
file://, filesystem:// and other nonstandard URLs (data:, blob: etc) is
displayed as "This page says" instead.

BUG=584759
==========

[meacer, 2016-02-05 21:38:01]

Description was changed from

==========
Long domain names can embiggen alert() dialogs beyond the limits. To prevent
that, show elided hostnames instead of security origin. Dialog title for
file://, filesystem:// and other nonstandard URLs (data:, blob: etc) is
displayed as "This page says" instead.

BUG=584759
==========

to

==========
Long domain names can embiggen alert() dialogs beyond the limits. To prevent
that, show elided hostnames instead of security origin. Dialog title for
file://,
filesystem:// and other nonstandard URLs (data:, blob: etc) is displayed as
"This page says" instead. Android already elides the dialog title, although in
the
other direction.

BUG=584759
==========

[meacer, 2016-02-05 21:40:59]

meacer@chromium.org changed reviewers:
+ avi@chromium.org

[meacer, 2016-02-05 21:40:59]

avi: Yet another one. WDYT?

There is a test page at http://go/long_hostname_is_long (will need to click
through SB warning and then trigger an alert from console)

[meacer, 2016-02-05 22:35:40]

Description was changed from

==========
Long domain names can embiggen alert() dialogs beyond the limits. To prevent
that, show elided hostnames instead of security origin. Dialog title for
file://,
filesystem:// and other nonstandard URLs (data:, blob: etc) is displayed as
"This page says" instead. Android already elides the dialog title, although in
the
other direction.

BUG=584759
==========

to

==========
Show elided hostnames in modal dialog titles

Long domain names can embiggen alert() dialogs beyond the limits. To prevent
that, show elided hostnames instead of security origin. Dialog title for
file://,
filesystem:// and other nonstandard URLs (data:, blob: etc) is displayed as
"This page says" instead. Android already elides the dialog title, although in
the
other direction.

BUG=584759
==========

[Avi (use Gerrit), 2016-02-06 07:11:38]

LGTM

I'm reasonably satisfied here. The "security" call handles things like file or
filesystem URLs, and we're already not doing those.

[meacer, 2016-02-08 18:23:10]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2016-02-08 18:25:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676693002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676693002/40001

[commit-bot: I haz the power, 2016-02-08 19:42:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-08 19:42:10]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[meacer, 2016-02-08 20:02:34]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2016-02-08 20:06:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676693002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676693002/40001

[commit-bot: I haz the power, 2016-02-08 21:43:41]

Description was changed from

==========
Show elided hostnames in modal dialog titles

Long domain names can embiggen alert() dialogs beyond the limits. To prevent
that, show elided hostnames instead of security origin. Dialog title for
file://,
filesystem:// and other nonstandard URLs (data:, blob: etc) is displayed as
"This page says" instead. Android already elides the dialog title, although in
the
other direction.

BUG=584759
==========

to

==========
Show elided hostnames in modal dialog titles

Long domain names can embiggen alert() dialogs beyond the limits. To prevent
that, show elided hostnames instead of security origin. Dialog title for
file://,
filesystem:// and other nonstandard URLs (data:, blob: etc) is displayed as
"This page says" instead. Android already elides the dialog title, although in
the
other direction.

BUG=584759
==========

[commit-bot: I haz the power, 2016-02-08 21:43:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-08 21:45:45]

Description was changed from

==========
Show elided hostnames in modal dialog titles

Long domain names can embiggen alert() dialogs beyond the limits. To prevent
that, show elided hostnames instead of security origin. Dialog title for
file://,
filesystem:// and other nonstandard URLs (data:, blob: etc) is displayed as
"This page says" instead. Android already elides the dialog title, although in
the
other direction.

BUG=584759
==========

to

==========
Show elided hostnames in modal dialog titles

Long domain names can embiggen alert() dialogs beyond the limits. To prevent
that, show elided hostnames instead of security origin. Dialog title for
file://,
filesystem:// and other nonstandard URLs (data:, blob: etc) is displayed as
"This page says" instead. Android already elides the dialog title, although in
the
other direction.

BUG=584759

Committed: https://crrev.com/5b6d71ddab30d1ce2fcb355c1c2e41d4218594c1
Cr-Commit-Position: refs/heads/master@{#374187}
==========

[commit-bot: I haz the power, 2016-02-08 21:45:46]

Patchset 3 (id:??) landed as
https://crrev.com/5b6d71ddab30d1ce2fcb355c1c2e41d4218594c1
Cr-Commit-Position: refs/heads/master@{#374187}