Issue 167653002: Make importNode work when the XML document contains a CDATA section

Issue 167653002: Make importNode work when the XML document contains a CDATA section (Closed)

Created:
6 years, 10 months ago by rwlbuis

Modified:
6 years, 6 months ago

Reviewers:
eseidel, esprehn, adamk, abarth-chromium

CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive, esprehn

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Make importNode work when the XML document contains a CDATA section Make importNode work when the XML document contains a CDATA section by avoiding calling createCDATASection since createCDATASection throws an exception for HTML Documents. The new behavior matches Firefox. BUG=340059 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175169

Patch Set 1 #

Patch Set 2 : Add testcase #

Total comments: 1

Patch Set 3 : Create CDATASection directly in importNode #

Total comments: 5

Patch Set 4 : Rebase and fix test #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -1 line)			Patch
A	LayoutTests/fast/dom/importNode-cdata.html	View	1 2 3	1 chunk	+22 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/importNode-cdata-expected.txt	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

rwlbuis

PTAL. Or let me know if there is a better candidate to review this :)

6 years, 10 months ago (2014-02-18 19:41:36 UTC) #1

adamk

Please rewrite the change description to explain what this change does, rather than simply what ...

6 years, 10 months ago (2014-02-19 17:04:59 UTC) #3

rwlbuis

On 2014/02/19 17:04:59, adamk wrote: > Please rewrite the change description to explain what this ...

6 years, 10 months ago (2014-02-19 18:56:47 UTC) #4

esprehn

lgtm, please fix the test and expand the change description before landing. Specifically mention that ...

6 years, 6 months ago (2014-05-30 01:53:32 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/167653002/300001

6 years, 6 months ago (2014-05-30 20:31:28 UTC) #8

Message was sent while issue was closed.

Change committed as 175169

Expand Messages | Collapse Messages