Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 167653002: Make importNode work when the XML document contains a CDATA section (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase and fix test Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/dom/importNode-cdata-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 927 matching lines...) Expand 10 before | Expand all | Expand 10 after
938 { 938 {
939 if (!importedNode) { 939 if (!importedNode) {
940 exceptionState.throwDOMException(NotSupportedError, ExceptionMessages::a rgumentNullOrIncorrectType(1, "Node")); 940 exceptionState.throwDOMException(NotSupportedError, ExceptionMessages::a rgumentNullOrIncorrectType(1, "Node"));
941 return nullptr; 941 return nullptr;
942 } 942 }
943 943
944 switch (importedNode->nodeType()) { 944 switch (importedNode->nodeType()) {
945 case TEXT_NODE: 945 case TEXT_NODE:
946 return createTextNode(importedNode->nodeValue()); 946 return createTextNode(importedNode->nodeValue());
947 case CDATA_SECTION_NODE: 947 case CDATA_SECTION_NODE:
948 return createCDATASection(importedNode->nodeValue(), exceptionState); 948 return CDATASection::create(*this, importedNode->nodeValue());
949 case PROCESSING_INSTRUCTION_NODE: 949 case PROCESSING_INSTRUCTION_NODE:
950 return createProcessingInstruction(importedNode->nodeName(), importedNod e->nodeValue(), exceptionState); 950 return createProcessingInstruction(importedNode->nodeName(), importedNod e->nodeValue(), exceptionState);
951 case COMMENT_NODE: 951 case COMMENT_NODE:
952 return createComment(importedNode->nodeValue()); 952 return createComment(importedNode->nodeValue());
953 case DOCUMENT_TYPE_NODE: { 953 case DOCUMENT_TYPE_NODE: {
954 DocumentType* doctype = toDocumentType(importedNode); 954 DocumentType* doctype = toDocumentType(importedNode);
955 return DocumentType::create(this, doctype->name(), doctype->publicId(), doctype->systemId()); 955 return DocumentType::create(this, doctype->name(), doctype->publicId(), doctype->systemId());
956 } 956 }
957 case ELEMENT_NODE: { 957 case ELEMENT_NODE: {
958 Element* oldElement = toElement(importedNode); 958 Element* oldElement = toElement(importedNode);
(...skipping 4842 matching lines...) Expand 10 before | Expand all | Expand 10 after
5801 visitor->trace(m_timeline); 5801 visitor->trace(m_timeline);
5802 visitor->trace(m_compositorPendingAnimations); 5802 visitor->trace(m_compositorPendingAnimations);
5803 visitor->registerWeakMembers<Document, &Document::clearWeakMembers>(this); 5803 visitor->registerWeakMembers<Document, &Document::clearWeakMembers>(this);
5804 DocumentSupplementable::trace(visitor); 5804 DocumentSupplementable::trace(visitor);
5805 TreeScope::trace(visitor); 5805 TreeScope::trace(visitor);
5806 ContainerNode::trace(visitor); 5806 ContainerNode::trace(visitor);
5807 ExecutionContext::trace(visitor); 5807 ExecutionContext::trace(visitor);
5808 } 5808 }
5809 5809
5810 } // namespace WebCore 5810 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/dom/importNode-cdata-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698