Subzero: Use a proper RegNumT type instead of int32_t/SizeT.

src/IceRegistersMIPS32.h

Index: src/IceRegistersMIPS32.h
diff --git a/src/IceRegistersMIPS32.h b/src/IceRegistersMIPS32.h
index 89c4d8925da229eb9bfb6bb07674f9fe53c38068..a7072841ed14e9c92964c8cb36cc108b260219f5 100644
--- a/src/IceRegistersMIPS32.h
+++ b/src/IceRegistersMIPS32.h
@@ -53,12 +53,13 @@ enum GPRRegister {
 // TODO(jvoung): Floating point and vector registers...
 // Need to model overlap and difference in encoding too.
 
-static inline GPRRegister getEncodedGPR(int32_t RegNum) {
-  assert(Reg_GPR_First <= RegNum && RegNum <= Reg_GPR_Last);
+static inline GPRRegister getEncodedGPR(RegNumT RegNum) {
+  assert(int(Reg_GPR_First) <= int(RegNum));

[Eric Holk, 2016/02/08 19:37:10]

Again, is this the sort of place fixme should be used?

[Jim Stichnoth, 2016/02/09 19:33:39]

This would be especially hard to represent in RegNumT, I think, because it's not
only dependent on the target, but also specifically about whether the register
value represents a GPR or not.

Probably the right approach here would be to use an x-macro table to validate
the GPR status and hold the encoded value.  Since Reed is trying to follow the
ARM CL trail, it will probably end up that way in time.

[Eric Holk, 2016/02/10 01:11:30]

That makes sense.

+  assert(unsigned(RegNum) <= Reg_GPR_Last);
   return GPRRegister(RegNum - Reg_GPR_First);
 }
 
-const char *getRegName(int32_t RegNum);
+const char *getRegName(RegNumT RegNum);
 
 } // end of namespace RegMIPS32