Extract webkit_unit_tests from blink_web component.

Extract webkit_unit_tests from blink_web component.

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build system, like most
  of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which can be used
  to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component in component
  (shared_library) builds.
- Handle MSVC C4275 issues: base classes are either exported or, if they are
  clearly pure-interface or pure-data, marked to suppress the warning.
- Adds an explicit web -> base dependency (due to platform using base, and gyp
  not propagating this). This is similar to the equivalent in core.
- Unexports WebRTCDataChannelHandlerClient. It's not exported from blink_web,
  and only happened to work before because one of the modules unit tests included
  the header, and that was previously linked into blink_web.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749
Committed: https://crrev.com/401833786b54e6b043f2c9b72f97b8fa377156c3
Cr-Commit-Position: refs/heads/master@{#378954}

[jbroman, 2016-02-06 23:15:39]

Description was changed from

==========
WIP: extract webkit_unit_tests from blink_web component

DO NOT SUBMIT. NOT FOR REVIEW.

BUG=
==========

to

==========
WIP: extract webkit_unit_tests from blink_web component

DO NOT SUBMIT. NOT FOR REVIEW.

BUG=412064
==========

[jbroman, 2016-02-29 15:53:47]

Description was changed from

==========
WIP: extract webkit_unit_tests from blink_web component

DO NOT SUBMIT. NOT FOR REVIEW.

BUG=412064
==========

to

==========
Extract webkit_unit_tests from blink_web component.

DO NOT SUBMIT. NOT FOR REVIEW.

BUG=590749
==========

[jbroman, 2016-02-29 16:41:03]

Description was changed from

==========
Extract webkit_unit_tests from blink_web component.

DO NOT SUBMIT. NOT FOR REVIEW.

BUG=590749
==========

to

==========
Extract webkit_unit_tests from blink_web component.

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build
  system, like most of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which
  can be used to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component
  in component (shared_library) builds.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on.

BUG=590749
==========

[jbroman, 2016-02-29 16:41:32]

Description was changed from

==========
Extract webkit_unit_tests from blink_web component.

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build
  system, like most of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which
  can be used to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component
  in component (shared_library) builds.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on.

BUG=590749
==========

to

==========
Extract webkit_unit_tests from blink_web component.

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build
  system, like most of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which
  can be used to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component
  in component (shared_library) builds.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749
==========

[jbroman, 2016-02-29 18:14:26]

Description was changed from

==========
Extract webkit_unit_tests from blink_web component.

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build
  system, like most of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which
  can be used to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component
  in component (shared_library) builds.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749
==========

to

==========
Extract webkit_unit_tests from blink_web component.

12345678901234567890123456789012345678901234567890123456789012345678901234567890

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build system, like most
  of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which can be used
  to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component in component
  (shared_library) builds.
- Handles MSVC C4275 issues: base classes are either exported or, if they are
  pure-interface or pure-data, marked to suppress the warning.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749
==========

[jbroman, 2016-02-29 18:14:37]

Description was changed from

==========
Extract webkit_unit_tests from blink_web component.

12345678901234567890123456789012345678901234567890123456789012345678901234567890

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build system, like most
  of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which can be used
  to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component in component
  (shared_library) builds.
- Handles MSVC C4275 issues: base classes are either exported or, if they are
  pure-interface or pure-data, marked to suppress the warning.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749
==========

to

==========
Extract webkit_unit_tests from blink_web component.

12345678901234567890123456789012345678901234567890123456789012345678901234567890

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build system, like most
  of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which can be used
  to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component in component
  (shared_library) builds.
- Handles MSVC C4275 issues: base classes are either exported or, if they are
  clearly pure-interface or pure-data, marked to suppress the warning.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749
==========

[jbroman, 2016-02-29 19:34:47]

Description was changed from

==========
Extract webkit_unit_tests from blink_web component.

12345678901234567890123456789012345678901234567890123456789012345678901234567890

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build system, like most
  of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which can be used
  to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component in component
  (shared_library) builds.
- Handles MSVC C4275 issues: base classes are either exported or, if they are
  clearly pure-interface or pure-data, marked to suppress the warning.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749
==========

to

==========
Extract webkit_unit_tests from blink_web component.

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build system, like most
  of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which can be used
  to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component in component
  (shared_library) builds.
- Handles MSVC C4275 issues: base classes are either exported or, if they are
  clearly pure-interface or pure-data, marked to suppress the warning.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749
==========

[jbroman, 2016-02-29 21:11:49]

Description was changed from

==========
Extract webkit_unit_tests from blink_web component.

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build system, like most
  of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which can be used
  to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component in component
  (shared_library) builds.
- Handles MSVC C4275 issues: base classes are either exported or, if they are
  clearly pure-interface or pure-data, marked to suppress the warning.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749
==========

to

==========
Extract webkit_unit_tests from blink_web component.

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build system, like most
  of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which can be used
  to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component in component
  (shared_library) builds.
- Handle MSVC C4275 issues: base classes are either exported or, if they are
  clearly pure-interface or pure-data, marked to suppress the warning.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749
==========

[jbroman, 2016-02-29 22:28:57]

Description was changed from

==========
Extract webkit_unit_tests from blink_web component.

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build system, like most
  of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which can be used
  to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component in component
  (shared_library) builds.
- Handle MSVC C4275 issues: base classes are either exported or, if they are
  clearly pure-interface or pure-data, marked to suppress the warning.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749
==========

to

==========
Extract webkit_unit_tests from blink_web component.

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build system, like most
  of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which can be used
  to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component in component
  (shared_library) builds.
- Handle MSVC C4275 issues: base classes are either exported or, if they are
  clearly pure-interface or pure-data, marked to suppress the warning.
- Adds an explicit web -> base dependency (due to platform using base, and gyp
  not propagating this). This is similar to the equivalent in core.
- Unexports WebRTCDataChannelHandlerClient. It's not exported from blink_web,
  and only happened to work before because one of the modules unit tests
included
  the header, and that was previously linked into blink_web.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749
==========

[jbroman, 2016-03-01 01:38:01]

jbroman@chromium.org changed reviewers:
+ haraken@chromium.org

[jbroman, 2016-03-01 01:38:02]

I'll probably wait a couple days to make sure the LINK_CORE_MODULES_SEPARATELY
inlining has stuck before landing this, but here's a CL that moves the unit test
code out of the blink_web component, and into the webkit_unit_tests binary,
where it belongs.

This means that building a component build of Chrome won't implicitly build
webkit_unit_tests, that libblink_web.so is much smaller, and if this lands, I
have a few followup patches to remove hacks that exist due to this setup.

re. NON_EXPORTED_BASE, MSVC emits a warning if an exported class has a
superclass which isn't exported. That prevents cases where two different DLLs
have copies of the superclass with different global state. Source/platform/
seems to work around this by globally suppressing the warning, and some other
places just export every class.

Instead, I've followed the pattern used in most of Chromium, exporting
non-trivial base classes, but leaving ones that are pure interfaces or wrap
simple data in the class non-exported. This requires whitelisting superclasses,
for which I've cloned the Chromium macro.

[haraken, 2016-03-01 02:41:06]

LGTM

https://codereview.chromium.org/1676083002/diff/280001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/ExternalPopupMenu.h (right):

https://codereview.chromium.org/1676083002/diff/280001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/ExternalPopupMenu.h:53: class WEB_EXPORT
ExternalPopupMenu final : WTF_NON_EXPORTED_BASE(public PopupMenu), public
WebExternalPopupMenuClient {

What is WTF_NON_EXPORTED_BASE for? In other words, when do we need to use it?

[jbroman, 2016-03-01 02:50:21]

On 2016/03/01 at 02:41:06, haraken wrote:
> LGTM
> 
>
https://codereview.chromium.org/1676083002/diff/280001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/web/ExternalPopupMenu.h (right):
> 
>
https://codereview.chromium.org/1676083002/diff/280001/third_party/WebKit/Sou...
> third_party/WebKit/Source/web/ExternalPopupMenu.h:53: class WEB_EXPORT
ExternalPopupMenu final : WTF_NON_EXPORTED_BASE(public PopupMenu), public
WebExternalPopupMenuClient {
> 
> What is WTF_NON_EXPORTED_BASE for? In other words, when do we need to use it?

It suppresses MSVC's C4275 warning, which complains when a class exported from a
DLL has a base class that isn't exported from a DLL. The point of the warning is
that if there is some class inlined in two separate DLLs, and there is global
state that it modifies, that state wouldn't be properly shared (which leads to
confusing bugs).

In cases where that's clearly not an issue (interfaces and small data objects,
mainly), it's quicker and more lightweight to just suppress the warning using
NON_EXPORTED_BASE (or WTF_NON_EXPORTED_BASE in Blink) rather than trying to pick
a component to export it. I've just added it where the Win debug bot complains
(except a few things, like PluginView, that should be exported).

I've copied the macro from base/compiler_specific.h (Chromium does the same
thing).
https://chromium.googlesource.com/chromium/src/+/af01e762/base/compiler_speci...
has a longer comment.

[jbroman, 2016-03-01 02:50:59]

jbroman@chromium.org changed reviewers:
+ pdr@chromium.org

[jbroman, 2016-03-01 02:50:59]

+pdr for public/

[pdr., 2016-03-01 02:54:50]

On 2016/03/01 at 02:50:59, jbroman wrote:
> +pdr for public/

LGTM

[jbroman, 2016-03-01 14:19:47]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 14:19:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676083002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676083002/300001

[commit-bot: I haz the power, 2016-03-01 15:37:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 15:37:48]

Dry run: This issue passed the CQ dry run.

[jbroman, 2016-03-02 15:17:09]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-02 15:17:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676083002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676083002/300001

[jbroman, 2016-03-02 16:21:38]

The CQ bit was unchecked by jbroman@chromium.org

[jbroman, 2016-03-02 16:22:41]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2016-03-02 16:22:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1676083002/#ps300001
(title: "revert content/ change -- it is not exported")

[commit-bot: I haz the power, 2016-03-02 16:22:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676083002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676083002/300001

[commit-bot: I haz the power, 2016-03-02 18:18:15]

Committed patchset #16 (id:300001)

[commit-bot: I haz the power, 2016-03-02 18:19:59]

Description was changed from

==========
Extract webkit_unit_tests from blink_web component.

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build system, like most
  of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which can be used
  to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component in component
  (shared_library) builds.
- Handle MSVC C4275 issues: base classes are either exported or, if they are
  clearly pure-interface or pure-data, marked to suppress the warning.
- Adds an explicit web -> base dependency (due to platform using base, and gyp
  not propagating this). This is similar to the equivalent in core.
- Unexports WebRTCDataChannelHandlerClient. It's not exported from blink_web,
  and only happened to work before because one of the modules unit tests
included
  the header, and that was previously linked into blink_web.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749
==========

to

==========
Extract webkit_unit_tests from blink_web component.

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build system, like most
  of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which can be used
  to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component in component
  (shared_library) builds.
- Handle MSVC C4275 issues: base classes are either exported or, if they are
  clearly pure-interface or pure-data, marked to suppress the warning.
- Adds an explicit web -> base dependency (due to platform using base, and gyp
  not propagating this). This is similar to the equivalent in core.
- Unexports WebRTCDataChannelHandlerClient. It's not exported from blink_web,
  and only happened to work before because one of the modules unit tests
included
  the header, and that was previously linked into blink_web.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749

Committed: https://crrev.com/737c4d032a36133f1045a3e399c922a948b29f85
Cr-Commit-Position: refs/heads/master@{#378773}
==========

[commit-bot: I haz the power, 2016-03-02 18:20:00]

Patchset 16 (id:??) landed as
https://crrev.com/737c4d032a36133f1045a3e399c922a948b29f85
Cr-Commit-Position: refs/heads/master@{#378773}

[Dmitry Titov, 2016-03-02 22:04:46]

A revert of this CL (patchset #16 id:300001) has been created in
https://codereview.chromium.org/1756343002/ by dimich@chromium.org.

The reason for reverting is: Broke compile:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilp....

[jbroman, 2016-03-03 01:23:18]

Description was changed from

==========
Extract webkit_unit_tests from blink_web component.

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build system, like most
  of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which can be used
  to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component in component
  (shared_library) builds.
- Handle MSVC C4275 issues: base classes are either exported or, if they are
  clearly pure-interface or pure-data, marked to suppress the warning.
- Adds an explicit web -> base dependency (due to platform using base, and gyp
  not propagating this). This is similar to the equivalent in core.
- Unexports WebRTCDataChannelHandlerClient. It's not exported from blink_web,
  and only happened to work before because one of the modules unit tests
included
  the header, and that was previously linked into blink_web.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749

Committed: https://crrev.com/737c4d032a36133f1045a3e399c922a948b29f85
Cr-Commit-Position: refs/heads/master@{#378773}
==========

to

==========
Extract webkit_unit_tests from blink_web component.

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build system, like most
  of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which can be used
  to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component in component
  (shared_library) builds.
- Handle MSVC C4275 issues: base classes are either exported or, if they are
  clearly pure-interface or pure-data, marked to suppress the warning.
- Adds an explicit web -> base dependency (due to platform using base, and gyp
  not propagating this). This is similar to the equivalent in core.
- Unexports WebRTCDataChannelHandlerClient. It's not exported from blink_web,
  and only happened to work before because one of the modules unit tests
included
  the header, and that was previously linked into blink_web.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749
==========

[jbroman, 2016-03-03 01:28:39]

On 2016/03/02 at 22:04:46, dimich wrote:
> A revert of this CL (patchset #16 id:300001) has been created in
https://codereview.chromium.org/1756343002/ by dimich@chromium.org.
> 
> The reason for reverting is: Broke compile:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilp....

Fix is easy (but my Windows compile was so slow it took this long for me to
verify): exporting TextFinder caused Windows to compile its implicit copy
constructor. In non-Oilpan builds, this fails because Vector<OwnPtr<T>> isn't
copyable. The solution is to mark the class (which isn't intended to be copied)
with WTF_MAKE_NONCOPYABLE, thus deleting the copy constructor (and assignment
operator).

I've verified locally that a Windows debug component non-Oilpan build does work.
Re-CQing.

[jbroman, 2016-03-03 01:28:43]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2016-03-03 01:28:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1676083002/#ps320001
(title: "Win dbg non-oilpan fix: make TextFinder non-copyable")

[commit-bot: I haz the power, 2016-03-03 01:29:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676083002/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676083002/320001

[commit-bot: I haz the power, 2016-03-03 01:53:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 01:53:38]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbroman, 2016-03-03 02:07:17]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2016-03-03 02:07:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1676083002/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1676083002/320001

[commit-bot: I haz the power, 2016-03-03 04:19:57]

Committed patchset #17 (id:320001)

[commit-bot: I haz the power, 2016-03-03 04:22:08]

Description was changed from

==========
Extract webkit_unit_tests from blink_web component.

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build system, like most
  of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which can be used
  to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component in component
  (shared_library) builds.
- Handle MSVC C4275 issues: base classes are either exported or, if they are
  clearly pure-interface or pure-data, marked to suppress the warning.
- Adds an explicit web -> base dependency (due to platform using base, and gyp
  not propagating this). This is similar to the equivalent in core.
- Unexports WebRTCDataChannelHandlerClient. It's not exported from blink_web,
  and only happened to work before because one of the modules unit tests
included
  the header, and that was previously linked into blink_web.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749
==========

to

==========
Extract webkit_unit_tests from blink_web component.

- Make BLINK_WEB_IMPLEMENTATION a define exported by the build system, like most
  of the others, rather than defined in a header.
- Create a WebExport.h header (similar to CoreExport.h, etc.) which can be used
  to export symbols from blink_web to webkit_unit_tests.
- Export symbols used from unit tests that aren't yet exported.
- Remove build logic to compile unit tests into blink_web component in component
  (shared_library) builds.
- Handle MSVC C4275 issues: base classes are either exported or, if they are
  clearly pure-interface or pure-data, marked to suppress the warning.
- Adds an explicit web -> base dependency (due to platform using base, and gyp
  not propagating this). This is similar to the equivalent in core.
- Unexports WebRTCDataChannelHandlerClient. It's not exported from blink_web,
  and only happened to work before because one of the modules unit tests
included
  the header, and that was previously linked into blink_web.

This makes the blink_web component substantially smaller, as it no
longer pulls in unit tests, gtest, and so on. It also unblocks
removal of several hacks that existed to accommodate the previous
setup.

BUG=590749

Committed: https://crrev.com/401833786b54e6b043f2c9b72f97b8fa377156c3
Cr-Commit-Position: refs/heads/master@{#378954}
==========

[commit-bot: I haz the power, 2016-03-03 04:22:09]

Patchset 17 (id:??) landed as
https://crrev.com/401833786b54e6b043f2c9b72f97b8fa377156c3
Cr-Commit-Position: refs/heads/master@{#378954}