Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: third_party/WebKit/Source/web/WebFrameImplBase.h

Issue 1676083002: Extract webkit_unit_tests from blink_web component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Win dbg non-oilpan fix: make TextFinder non-copyable Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebFrameImplBase_h 5 #ifndef WebFrameImplBase_h
6 #define WebFrameImplBase_h 6 #define WebFrameImplBase_h
7 7
8 #include "platform/heap/Handle.h" 8 #include "platform/heap/Handle.h"
9 #include "web/WebExport.h"
9 #include "wtf/text/AtomicString.h" 10 #include "wtf/text/AtomicString.h"
10 11
11 namespace blink { 12 namespace blink {
12 13
13 class Frame; 14 class Frame;
14 class FrameHost; 15 class FrameHost;
15 class FrameOwner; 16 class FrameOwner;
16 17
17 // WebFrameImplBase exists to avoid the diamond inheritance problem: 18 // WebFrameImplBase exists to avoid the diamond inheritance problem:
18 // - The public interfaces WebLocalFrame/WebRemoteFrame extend WebFrame. 19 // - The public interfaces WebLocalFrame/WebRemoteFrame extend WebFrame.
19 // - WebLocalFrameImpl implements WebLocalFrame and WebRemoteFrameImpl 20 // - WebLocalFrameImpl implements WebLocalFrame and WebRemoteFrameImpl
20 // implements WebRemoteFrame. 21 // implements WebRemoteFrame.
21 // - The private implementations should share some functionality, but cannot 22 // - The private implementations should share some functionality, but cannot
22 // inherit from a common base class inheriting WebFrame. This would result in 23 // inherit from a common base class inheriting WebFrame. This would result in
23 // WebFrame beind inherited from two different base classes. 24 // WebFrame beind inherited from two different base classes.
24 // 25 //
25 // To get around this, only the private implementations have WebFrameImplBase as 26 // To get around this, only the private implementations have WebFrameImplBase as
26 // a base class. WebFrame exposes a virtual accessor to retrieve the underlying 27 // a base class. WebFrame exposes a virtual accessor to retrieve the underlying
27 // implementation as an instance of the base class, but has no inheritance 28 // implementation as an instance of the base class, but has no inheritance
28 // relationship with it. The cost is a virtual indirection, but this is nicer 29 // relationship with it. The cost is a virtual indirection, but this is nicer
29 // than the previous manual dispatch emulating real virtual dispatch. 30 // than the previous manual dispatch emulating real virtual dispatch.
30 class WebFrameImplBase : public RefCountedWillBeGarbageCollectedFinalized<WebFra meImplBase> { 31 class WEB_EXPORT WebFrameImplBase : public RefCountedWillBeGarbageCollectedFinal ized<WebFrameImplBase> {
31 public: 32 public:
32 virtual ~WebFrameImplBase(); 33 virtual ~WebFrameImplBase();
33 34
34 virtual void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString & name, const AtomicString& uniqueName) = 0; 35 virtual void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString & name, const AtomicString& uniqueName) = 0;
35 // TODO(dcheng): Rename this to coreFrame()? This probably also shouldn't be const... 36 // TODO(dcheng): Rename this to coreFrame()? This probably also shouldn't be const...
36 virtual Frame* frame() const = 0; 37 virtual Frame* frame() const = 0;
37 38
38 DECLARE_VIRTUAL_TRACE(); 39 DECLARE_VIRTUAL_TRACE();
39 }; 40 };
40 41
41 } // namespace blink 42 } // namespace blink
42 43
43 #endif // WebFrameImplBase_h 44 #endif // WebFrameImplBase_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebExport.h ('k') | third_party/WebKit/Source/web/WebInputEventConversion.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698