Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1676003002:
Fix MSAN error for r373917. (Closed)
|
Created:
4 years, 10 months ago by dcheng Modified:
4 years, 10 months ago Reviewers:
sof CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix MSAN error for r373917.
The new member wasn't being set in the copy constructor; to prevent
future errors like this, the copy constructor is now explicitly
defaulted.
BUG=583445, 584895
Committed: https://crrev.com/48d1fd093dcfe72cdb5545c12469a3d20cff18ea
Cr-Commit-Position: refs/heads/master@{#374029}
Patch Set 1 #
Messages
Total messages: 26 (14 generated)
dcheng@chromium.org changed reviewers: + sigbjornf@opera.com
The CQ bit was checked by dcheng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676003002/1
lgtm
Description was changed from ========== Fix MSAN error for r373917. The new member wasn't being set in the copy constructor; to prevent future errors like this, the copy constructor is now explicitly defaulted. BUG=583445 ========== to ========== Fix MSAN error for r373917. The new member wasn't being set in the copy constructor; to prevent future errors like this, the copy constructor is now explicitly defaulted. BUG=583445,584895 ==========
The CQ bit was checked by dcheng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676003002/1
The CQ bit was unchecked by sigbjornf@opera.com
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676003002/1
Kicked off https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... with r374023 in scope.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix MSAN error for r373917. The new member wasn't being set in the copy constructor; to prevent future errors like this, the copy constructor is now explicitly defaulted. BUG=583445,584895 ========== to ========== Fix MSAN error for r373917. The new member wasn't being set in the copy constructor; to prevent future errors like this, the copy constructor is now explicitly defaulted. BUG=583445,584895 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_msan_rel_ng ==========
The CQ bit was checked by dcheng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676003002/1
Description was changed from ========== Fix MSAN error for r373917. The new member wasn't being set in the copy constructor; to prevent future errors like this, the copy constructor is now explicitly defaulted. BUG=583445,584895 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_msan_rel_ng ========== to ========== Fix MSAN error for r373917. The new member wasn't being set in the copy constructor; to prevent future errors like this, the copy constructor is now explicitly defaulted. BUG=583445,584895 ==========
The CQ bit was unchecked by sigbjornf@opera.com
ah, linux_chromium_msan_rel_ng doesn't run layout tests, so not too useful here. And slow to boot, so removing dependency & landing.
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676003002/1
Message was sent while issue was closed.
Description was changed from ========== Fix MSAN error for r373917. The new member wasn't being set in the copy constructor; to prevent future errors like this, the copy constructor is now explicitly defaulted. BUG=583445,584895 ========== to ========== Fix MSAN error for r373917. The new member wasn't being set in the copy constructor; to prevent future errors like this, the copy constructor is now explicitly defaulted. BUG=583445,584895 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix MSAN error for r373917. The new member wasn't being set in the copy constructor; to prevent future errors like this, the copy constructor is now explicitly defaulted. BUG=583445,584895 ========== to ========== Fix MSAN error for r373917. The new member wasn't being set in the copy constructor; to prevent future errors like this, the copy constructor is now explicitly defaulted. BUG=583445,584895 Committed: https://crrev.com/48d1fd093dcfe72cdb5545c12469a3d20cff18ea Cr-Commit-Position: refs/heads/master@{#374029} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/48d1fd093dcfe72cdb5545c12469a3d20cff18ea Cr-Commit-Position: refs/heads/master@{#374029} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
