Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 1675743002: Reorder ScriptLoader fields to help diagnose object inconsistency. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Reorder ScriptLoader fields to help diagnose object inconsistency. crbug.com/570012 is showing signs of a ScriptLoader field update not persisting on some platforms; reorder the fields to speculatively try to perturb status. R= BUG=570012 Review URL: https://codereview.chromium.org/1666093002 Cr-Commit-Position: refs/heads/master@{#373505} (cherry picked from commit b5009c973fed8fb182533ce24f7df9d843c05419) Conflicts: third_party/WebKit/Source/core/dom/ScriptLoader.cpp third_party/WebKit/Source/core/dom/ScriptLoader.h Committed: https://chromium.googlesource.com/chromium/src/+/c5d07e6b3fed7b343857440c7b3409870cda7356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/dom/ScriptLoader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sof
4 years, 10 months ago (2016-02-05 19:26:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c5d07e6b3fed7b343857440c7b3409870cda7356.

Powered by Google App Engine
This is Rietveld 408576698