Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1666093002: Reorder ScriptLoader fields to help diagnose object inconsistency. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reorder ScriptLoader fields to help diagnose object inconsistency. crbug.com/570012 is showing signs of a ScriptLoader field update not persisting on some platforms; reorder the fields to speculatively try to perturb status. R= BUG=570012 Committed: https://crrev.com/b5009c973fed8fb182533ce24f7df9d843c05419 Cr-Commit-Position: refs/heads/master@{#373505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/dom/ScriptLoader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look. see bug for info on why we're here.
4 years, 10 months ago (2016-02-04 09:03:11 UTC) #2
haraken
LGTM to try.
4 years, 10 months ago (2016-02-04 09:18:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1666093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1666093002/1
4 years, 10 months ago (2016-02-04 10:57:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 11:06:07 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 11:07:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5009c973fed8fb182533ce24f7df9d843c05419
Cr-Commit-Position: refs/heads/master@{#373505}

Powered by Google App Engine
This is Rietveld 408576698