Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1675693002: Update Token Binding TLS Extension number to IANA-allocated number (Closed)

Created:
4 years, 10 months ago by nharper
Modified:
4 years, 10 months ago
Reviewers:
davidben
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Token Binding TLS Extension number to IANA-allocated number BUG=467312 Committed: https://crrev.com/b5ad8a80d5e4bfebb071382166f096df3fdacd1e Cr-Commit-Position: refs/heads/master@{#373877}

Patch Set 1 #

Total comments: 2

Patch Set 2 : udpate -> update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/tlslite/README.chromium View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/tlslite/patches/extension_number_update.patch View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/tlslite/tlslite/constants.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
nharper
4 years, 10 months ago (2016-02-05 18:06:53 UTC) #2
davidben
lgtm https://codereview.chromium.org/1675693002/diff/1/third_party/tlslite/README.chromium File third_party/tlslite/README.chromium (right): https://codereview.chromium.org/1675693002/diff/1/third_party/tlslite/README.chromium#newcode52 third_party/tlslite/README.chromium:52: - patches/extension_number_udpate.patch: Update TLS extension numbers. udpate -> ...
4 years, 10 months ago (2016-02-05 18:20:38 UTC) #3
nharper
https://codereview.chromium.org/1675693002/diff/1/third_party/tlslite/README.chromium File third_party/tlslite/README.chromium (right): https://codereview.chromium.org/1675693002/diff/1/third_party/tlslite/README.chromium#newcode52 third_party/tlslite/README.chromium:52: - patches/extension_number_udpate.patch: Update TLS extension numbers. On 2016/02/05 18:20:38, ...
4 years, 10 months ago (2016-02-05 18:27:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675693002/20001
4 years, 10 months ago (2016-02-05 18:27:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-05 19:40:11 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 19:42:48 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b5ad8a80d5e4bfebb071382166f096df3fdacd1e
Cr-Commit-Position: refs/heads/master@{#373877}

Powered by Google App Engine
This is Rietveld 408576698