content/browser/service_worker/service_worker_version.h - Issue 1675613002: service worker: use 200 OK for update requests even in the no update case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 1675613002: service worker: use 200 OK for update requests even in the no update case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: asan and fix win compile? Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_registration.h ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index c09d5b5e1fcfcde3a6391a82163be02ad480b965..c5547f63925e518119d4678ddb44e2fe2047d2f6 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -316,9 +316,9 @@ class CONTENT_EXPORT ServiceWorkerVersion

force_bypass_cache_for_scripts_ = force_bypass_cache_for_scripts;

}

- bool skip_script_comparison() const { return skip_script_comparison_; }

- void set_skip_script_comparison(bool skip_script_comparison) {

- skip_script_comparison_ = skip_script_comparison;

+ bool pause_after_download() const { return pause_after_download_; }

+ void set_pause_after_download(bool pause_after_download) {

+ pause_after_download_ = pause_after_download;

}

void SetDevToolsAttached(bool attached);

@@ -699,7 +699,7 @@ class CONTENT_EXPORT ServiceWorkerVersion

bool skip_waiting_ = false;

bool skip_recording_startup_time_ = false;

bool force_bypass_cache_for_scripts_ = false;

- bool skip_script_comparison_ = false;

+ bool pause_after_download_ = false;

bool is_update_scheduled_ = false;

bool in_dtor_ = false;