content/browser/service_worker/service_worker_registration.h - Issue 1675613002: service worker: use 200 OK for update requests even in the no update case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration.h

Issue 1675613002: service worker: use 200 OK for update requests even in the no update case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: asan and fix win compile? Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_register_job.cc ('k') | content/browser/service_worker/service_worker_version.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration.h

diff --git a/content/browser/service_worker/service_worker_registration.h b/content/browser/service_worker/service_worker_registration.h

index 6f0ebe8eea7d9f21ea6352c462d99956f85cfb85..6f9b0dea86324e017147846e0aa8ebf85bbc2412 100644

--- a/content/browser/service_worker/service_worker_registration.h

+++ b/content/browser/service_worker/service_worker_registration.h

@@ -86,6 +86,10 @@ class CONTENT_EXPORT ServiceWorkerRegistration

return installing_version_.get();

}

+ bool has_installed_version() const {

+ return active_version() || waiting_version();

+ }

ServiceWorkerVersion* GetNewestVersion() const;

void AddListener(Listener* listener);