content/browser/service_worker/service_worker_version.cc - Issue 1675613002: service worker: use 200 OK for update requests even in the no update case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 1675613002: service worker: use 200 OK for update requests even in the no update case (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: asan and fix win compile? Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_version.h ('k') | content/browser/service_worker/service_worker_version_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.cc

diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc

index b4ce1c924ba0ea8e7222fec9d2009c05b4ada234..b59e0f9ad9661671b41d2fa5c543c0bac653809f 100644

--- a/content/browser/service_worker/service_worker_version.cc

+++ b/content/browser/service_worker/service_worker_version.cc

@@ -1350,10 +1350,12 @@ void ServiceWorkerVersion::StartWorkerInternal() {

if (!timeout_timer_.IsRunning())

StartTimeoutTimer();

if (running_status() == STOPPED) {

+ DCHECK(!pause_after_download_ || !IsInstalled(status()));

embedded_worker_->Start(

version_id_, scope_, script_url_,

base::Bind(&ServiceWorkerVersion::OnStartSentAndScriptEvaluated,

- weak_factory_.GetWeakPtr()));

+ weak_factory_.GetWeakPtr()),

+ pause_after_download_);

}