Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1675163003: Filter out invalid slots in store buffer eagerly during object transition. (Closed)

Created:
4 years, 10 months ago by ulan
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Filter out invalid slots in store buffer eagerly during object transition. BUG=chromium:578883 LOG=NO Committed: https://crrev.com/edde7b28f6816b6145d0707bfb2857aa5aa56503 Cr-Commit-Position: refs/heads/master@{#33841}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Enable WriteBarrierObjectShiftFieldsRight test and add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M src/heap/heap.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/store-buffer.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ulan
PTAL
4 years, 10 months ago (2016-02-08 20:16:45 UTC) #2
Hannes Payer (out of office)
LGTM!!! https://codereview.chromium.org/1675163003/diff/1/src/heap/store-buffer.h File src/heap/store-buffer.h (right): https://codereview.chromium.org/1675163003/diff/1/src/heap/store-buffer.h#newcode39 src/heap/store-buffer.h:39: void Remove(Address addr); For completeness, leave a comment.
4 years, 10 months ago (2016-02-08 21:17:25 UTC) #3
Igor Sheludko
lgtm. Please also enable test WriteBarrierObjectShiftFieldsRight.
4 years, 10 months ago (2016-02-09 10:13:40 UTC) #4
ulan
Thanks for the comments. Enabled the test :) https://codereview.chromium.org/1675163003/diff/1/src/heap/store-buffer.h File src/heap/store-buffer.h (right): https://codereview.chromium.org/1675163003/diff/1/src/heap/store-buffer.h#newcode39 src/heap/store-buffer.h:39: void ...
4 years, 10 months ago (2016-02-09 10:14:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675163003/20001
4 years, 10 months ago (2016-02-09 10:21:25 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-09 10:47:24 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 10:48:34 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/edde7b28f6816b6145d0707bfb2857aa5aa56503
Cr-Commit-Position: refs/heads/master@{#33841}

Powered by Google App Engine
This is Rietveld 408576698