src/heap/heap.cc - Issue 1675163003: Filter out invalid slots in store buffer eagerly during object transition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 1675163003: Filter out invalid slots in store buffer eagerly during object transition. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Enable WriteBarrierObjectShiftFieldsRight test and add comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index f40fe4b958d42afe3ad05ad12af7cfc25a4b8fe9..5a380a5affef1e1f95f2ddc0a593ce2b86825d13 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -5449,6 +5449,11 @@ void Heap::CheckHandleCount() {

isolate_->handle_scope_implementer()->Iterate(&v);

}

+void Heap::ClearRecordedSlot(HeapObject* object, Object** slot) {

+ if (!InNewSpace(object)) {

+ store_buffer()->Remove(reinterpret_cast<Address>(slot));

+ }

Space* AllSpaces::next() {

switch (counter_++) {

« no previous file with comments | « src/heap/heap.h ('k') | src/heap/store-buffer.h » ('j') | no next file with comments »