inject_script_tags no longer crashes when there is no body tag.

inject_script_tags no longer crashes when there is no body tag.

Previously, inject_script_tags would raise an AttributeError when given
HTML with no body tag. This CL fixes the function so that it works
regardless of whether there is a body tag.

Resolves https://github.com/chromium/caterpillar/issues/44 .

R=mgiuca@chromium.org

Committed: b59e08ac4c29309b9695b19451a8f454784b20ff

[Matthew Alger, 2016-02-08 03:08:46]

alger@google.com changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2016-02-08 04:28:39]

https://codereview.chromium.org/1675133002/diff/1/src/caterpillar.py
File src/caterpillar.py (right):

https://codereview.chromium.org/1675133002/diff/1/src/caterpillar.py#newcode279
src/caterpillar.py:279: target = soup
I'm confused; I thought you did this change awhile back and I remember writing a
comment like "instead of just adding it into the top-level directory, create a
new body element." And you did that...?

Is this some other code?

[Matthew Alger, 2016-02-08 04:29:57]

https://codereview.chromium.org/1675133002/diff/1/src/caterpillar.py
File src/caterpillar.py (right):

https://codereview.chromium.org/1675133002/diff/1/src/caterpillar.py#newcode279
src/caterpillar.py:279: target = soup
On 2016/02/08 04:28:39, Matt Giuca wrote:
> I'm confused; I thought you did this change awhile back and I remember writing
a
> comment like "instead of just adding it into the top-level directory, create a
> new body element." And you did that...?
> 
> Is this some other code?

That was head tags and in another function.

I think it doesn't make a lot of sense to add a body tag - I'm not sure how it
would be handled and if there's no body then everything is being thrown in
html/soup anyway.

[Matt Giuca, 2016-02-08 05:59:52]

lgtm

https://codereview.chromium.org/1675133002/diff/1/src/caterpillar.py
File src/caterpillar.py (right):

https://codereview.chromium.org/1675133002/diff/1/src/caterpillar.py#newcode279
src/caterpillar.py:279: target = soup
On 2016/02/08 04:29:57, Matthew Alger wrote:
> On 2016/02/08 04:28:39, Matt Giuca wrote:
> > I'm confused; I thought you did this change awhile back and I remember
writing
> a
> > comment like "instead of just adding it into the top-level directory, create
a
> > new body element." And you did that...?
> > 
> > Is this some other code?
> 
> That was head tags and in another function.
> 
> I think it doesn't make a lot of sense to add a body tag - I'm not sure how it
> would be handled and if there's no body then everything is being thrown in
> html/soup anyway.

Acknowledged.

[Matthew Alger, 2016-02-08 06:03:10]

Description was changed from

==========
inject_script_tags no longer crashes when there is no body tag.

Previously, inject_script_tags would raise an AttributeError when given
HTML with no body tag. This CL fixes the function so that it works
regardless of whether there is a body tag.

Resolves https://github.com/chromium/caterpillar/issues/44 .
==========

to

==========
inject_script_tags no longer crashes when there is no body tag.

Previously, inject_script_tags would raise an AttributeError when given
HTML with no body tag. This CL fixes the function so that it works
regardless of whether there is a body tag.

Resolves https://github.com/chromium/caterpillar/issues/44 .

R=mgiuca@chromium.org

Committed: b59e08ac4c29309b9695b19451a8f454784b20ff
==========

[Matthew Alger, 2016-02-08 06:03:13]

Committed patchset #1 (id:1) manually as
b59e08ac4c29309b9695b19451a8f454784b20ff (presubmit successful).