inject_script_tags no longer crashes when there is no body tag.

src/caterpillar.py

 #!/usr/bin/env python2
 # -*- coding: utf-8 -*-
 
 # Copyright 2015 Google Inc. All Rights Reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
 #     http://www.apache.org/licenses/LICENSE-2.0
@@ skipping 253 matching lines @@
   first_script = scripts[0] if scripts else None
 
   logging.debug('Requiring scripts: %s', ', '.join(required_js_paths))
 
   # Insert the script tags in order.
   for script_path in reversed(required_js_paths):
     logging.debug('Inserting `%s` script tag.', script_path)
     path = os.path.join(root_path, boilerplate_dir, script_path)
     script = soup.new_tag('script', src=path)
     if first_script is None:
-      soup.body.append(script)
+      target = soup.body
+      if not target:
+        if soup.html:
+          target = soup.html
+        else:
+          target = soup

[Matt Giuca, 2016/02/08 04:28:39]

I'm confused; I thought you did this change awhile back and I remember writing a
comment like "instead of just adding it into the top-level directory, create a
new body element." And you did that...?

Is this some other code?

[Matthew Alger, 2016/02/08 04:29:57]

That was head tags and in another function.

I think it doesn't make a lot of sense to add a body tag - I'm not sure how it
would be handled and if there's no body then everything is being thrown in
html/soup anyway.

[Matt Giuca, 2016/02/08 05:59:52]

Acknowledged.

+      target.append(script)
     else:
       first_script.insert_before(script)
     first_script = script
     logging.debug('Injected `%s` script into `%s`.', script_path, html_path)
 
 
 def inject_misc_tags(soup, chrome_app_manifest, root_path, html_path):
   """
   Injects meta and link tags into an HTML document.
 
@@ skipping 570 matching lines @@
     configuration.generate_and_save(args.output, args.interactive)
 
   elif args.mode == 'convert':
     config = configuration.load(args.config)
     convert_app(args.input, args.output, config, handler.captured_warnings,
                 args.force)
 
 
 if __name__ == '__main__':
   sys.exit(main())