Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 167513002: Merge 164396 "When an isolated run is appended, m_eor(End Of Run..." (Closed)

Created:
6 years, 10 months ago by eseidel
Modified:
6 years, 10 months ago
Reviewers:
igoroliveira
CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1
Visibility:
Public.

Description

Merge 164396 "When an isolated run is appended, m_eor(End Of Run..." > When an isolated run is appended, m_eor(End Of Run) is wrongly incremented. > Instead of moving to the next renderer, the iterator(m_eor) is just moving to the > next position in the same renderer. > > BUG=330974 > > Review URL: https://codereview.chromium.org/122553005 TBR=igor.o@sisa.samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, --1 lines) Patch
LayoutTests/fast/text/international/unicode-bidi-isolate-duplicated-text.html View 0 chunks +-1 lines, --1 lines 0 comments Download
LayoutTests/fast/text/international/unicode-bidi-isolate-duplicated-text-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
Source/core/rendering/InlineIterator.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
eseidel
6 years, 10 months ago (2014-02-14 19:35:30 UTC) #1
eseidel
6 years, 10 months ago (2014-02-14 19:35:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r167218.

Powered by Google App Engine
This is Rietveld 408576698