unicode-bidi: isolate is creating duplicated runs

When an isolated run is appended, m_eor(End Of Run) is wrongly incremented. 
Instead of moving to the next renderer, the iterator(m_eor) is just moving to the
next position in the same renderer.

BUG=330974
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164396

[leviw_travelin_and_unemployed, 2013-12-31 01:32:04]

Okay. LGTM.

[eseidel, 2013-12-31 01:38:14]

Should we move this logic into a helper function on the iterator?  Will we
need this logic elsewhere?

On Monday, December 30, 2013, wrote:

> Okay. LGTM.
>
> https://codereview.chromium.org/122553005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[igoroliveira, 2013-12-31 01:56:56]

Ideally, inside InlineIterator::increment(in fact the logic is already there). 
However the current code does not work because BidiResolver and IsolateTracker
use the same concept of inIsolate with different logic/meaning 
and InlineIterator::increment looks the BidiResolver to know if the current
renderer is isolated to move to the next renderer.
In the test. when m_eor.increment() is called BidiResolver::inIsolate is
false(but IsolateTracker::inIsolate is true) and the iterator moves to the next
position in the current renderer instead of moving to the next renderer. 

On 2013/12/31 01:38:14, eseidel wrote:
> Should we move this logic into a helper function on the iterator?  Will we
> need this logic elsewhere?
> 
> On Monday, December 30, 2013, wrote:
> 
> > Okay. LGTM.
> >
> > https://codereview.chromium.org/122553005/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:blink-reviews+unsubscribe@chromium.org.

[eseidel, 2013-12-31 03:00:54]

Ok. Please explain that somewhere in a comment in the code. :)
On Monday, December 30, 2013, wrote:

> Ideally, inside InlineIterator::increment(in fact the logic is already
> there).
> However the current code does not work because BidiResolver and
> IsolateTracker
> use the same concept of inIsolate with different logic/meaning
> and InlineIterator::increment looks the BidiResolver to know if the current
> renderer is isolated to move to the next renderer.
> In the test. when m_eor.increment() is called BidiResolver::inIsolate is
> false(but IsolateTracker::inIsolate is true) and the iterator moves to the
> next
> position in the current renderer instead of moving to the next renderer.
>
> On 2013/12/31 01:38:14, eseidel wrote:
>
>> Should we move this logic into a helper function on the iterator?  Will we
>> need this logic elsewhere?
>>
>
>  On Monday, December 30, 2013, wrote:
>>
>
>  > Okay. LGTM.
>> >
>> > https://codereview.chromium.org/122553005/
>> >
>>
>
>  To unsubscribe from this group and stop receiving emails from it, send an
>>
> email
>
>> to mailto:blink-reviews+unsubscribe@chromium.org.
>>
>
>
> https://codereview.chromium.org/122553005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-12-31 06:44:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/122553005/110001

[commit-bot: I haz the power, 2013-12-31 09:12:48]

Change committed as 164396