Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: mojo/shell/application_package_apptest.cc

Issue 1675083002: Rename ApplicationDelegate to ShellClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@delegate
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/application_manager_unittest.cc ('k') | mojo/shell/capability_filter_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/application_package_apptest.cc
diff --git a/mojo/shell/application_package_apptest.cc b/mojo/shell/application_package_apptest.cc
index 981f24551fe8bb498c4907a154c2467d5f220382..3d19daf712b7c4ef82242bd275c52f646786118d 100644
--- a/mojo/shell/application_package_apptest.cc
+++ b/mojo/shell/application_package_apptest.cc
@@ -30,7 +30,7 @@ using GetNameCallback =
test::mojom::ApplicationPackageApptestService::GetNameCallback;
class ProvidedApplicationDelegate
- : public ApplicationDelegate,
+ : public ShellClient,
public InterfaceFactory<test::mojom::ApplicationPackageApptestService>,
public test::mojom::ApplicationPackageApptestService,
public base::SimpleThread {
@@ -50,16 +50,16 @@ class ProvidedApplicationDelegate
}
private:
- // ApplicationDelegate:
+ // mojo::ShellClient:
void Initialize(Shell* shell, const std::string& url, uint32_t id) override {}
- bool AcceptConnection(ApplicationConnection* connection) override {
+ bool AcceptConnection(Connection* connection) override {
connection->AddService<test::mojom::ApplicationPackageApptestService>(this);
return true;
}
// InterfaceFactory<test::mojom::ApplicationPackageApptestService>:
void Create(
- ApplicationConnection* connection,
+ Connection* connection,
InterfaceRequest<test::mojom::ApplicationPackageApptestService> request)
override {
bindings_.AddBinding(this, std::move(request));
@@ -86,7 +86,7 @@ class ProvidedApplicationDelegate
};
class ApplicationPackageApptestDelegate
- : public ApplicationDelegate,
+ : public ShellClient,
public InterfaceFactory<mojom::ContentHandler>,
public InterfaceFactory<test::mojom::ApplicationPackageApptestService>,
public mojom::ContentHandler,
@@ -96,22 +96,22 @@ class ApplicationPackageApptestDelegate
~ApplicationPackageApptestDelegate() override {}
private:
- // ApplicationDelegate:
+ // mojo::ShellClient:
void Initialize(Shell* shell, const std::string& url, uint32_t id) override {}
- bool AcceptConnection(ApplicationConnection* connection) override {
+ bool AcceptConnection(Connection* connection) override {
connection->AddService<ContentHandler>(this);
connection->AddService<test::mojom::ApplicationPackageApptestService>(this);
return true;
}
// InterfaceFactory<mojom::ContentHandler>:
- void Create(ApplicationConnection* connection,
+ void Create(Connection* connection,
InterfaceRequest<mojom::ContentHandler> request) override {
content_handler_bindings_.AddBinding(this, std::move(request));
}
// InterfaceFactory<test::mojom::ApplicationPackageApptestService>:
- void Create(ApplicationConnection* connection,
+ void Create(Connection* connection,
InterfaceRequest<test::mojom::ApplicationPackageApptestService>
request) override {
bindings_.AddBinding(this, std::move(request));
@@ -136,7 +136,7 @@ class ApplicationPackageApptestDelegate
callback.Run("ROOT");
}
- std::vector<scoped_ptr<ApplicationDelegate>> delegates_;
+ std::vector<scoped_ptr<ShellClient>> delegates_;
WeakBindingSet<mojom::ContentHandler> content_handler_bindings_;
WeakBindingSet<test::mojom::ApplicationPackageApptestService> bindings_;
@@ -159,7 +159,7 @@ class ApplicationPackageApptest : public mojo::test::ApplicationTestBase {
private:
// test::ApplicationTestBase:
- ApplicationDelegate* GetApplicationDelegate() override {
+ ShellClient* GetShellClient() override {
delegate_ = new ApplicationPackageApptestDelegate;
return delegate_;
}
« no previous file with comments | « mojo/shell/application_manager_unittest.cc ('k') | mojo/shell/capability_filter_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698