mash/browser_driver/browser_driver_application_delegate.h - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mash/browser_driver/browser_driver_application_delegate.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mandoline/ui/phone_ui/phone_browser_application_delegate.cc ('k') | mash/browser_driver/browser_driver_application_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mash/browser_driver/browser_driver_application_delegate.h

diff --git a/mash/browser_driver/browser_driver_application_delegate.h b/mash/browser_driver/browser_driver_application_delegate.h

index 94bbdd5b32a34d00c8e96d0bc90d46a05dbf5c4e..f832308b3a9521addbd68d5c2200a680d378fbf1 100644

--- a/mash/browser_driver/browser_driver_application_delegate.h

+++ b/mash/browser_driver/browser_driver_application_delegate.h

@@ -31,7 +31,8 @@ class BrowserDriverApplicationDelegate : public mojo::ApplicationDelegate,

private:

// mojo::ApplicationDelegate:

- void Initialize(mojo::ApplicationImpl* app) override;

+ void Initialize(mojo::Shell* shell, const std::string& url,

+ uint32_t id) override;

bool AcceptConnection(

mojo::ApplicationConnection* connection) override;

@@ -40,7 +41,7 @@ class BrowserDriverApplicationDelegate : public mojo::ApplicationDelegate,

void AddAccelerators();

- mojo::ApplicationImpl* app_;

+ mojo::Shell* shell_;

mojo::Binding<mus::mojom::AcceleratorHandler> binding_;

DISALLOW_COPY_AND_ASSIGN(BrowserDriverApplicationDelegate);