Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: components/web_view/web_view_impl.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/web_view/web_view_apptest.cc ('k') | components/web_view/web_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/web_view/web_view_impl.h
diff --git a/components/web_view/web_view_impl.h b/components/web_view/web_view_impl.h
index 28e68660934b8f3ccf09c1c4c2101e133ae398cf..c66d258fef921f635eb657541bac275b3aedc181 100644
--- a/components/web_view/web_view_impl.h
+++ b/components/web_view/web_view_impl.h
@@ -25,7 +25,7 @@
#include "mojo/public/cpp/bindings/strong_binding.h"
namespace mojo {
-class ApplicationImpl;
+class Shell;
}
namespace web_view {
@@ -48,7 +48,7 @@ class WebViewImpl : public mojom::WebView,
public NavigationControllerDelegate,
public FindControllerDelegate {
public:
- WebViewImpl(mojo::ApplicationImpl* app,
+ WebViewImpl(mojo::Shell* shell,
mojom::WebViewClientPtr client,
mojo::InterfaceRequest<WebView> request);
~WebViewImpl() override;
@@ -116,7 +116,7 @@ class WebViewImpl : public mojom::WebView,
std::vector<Frame*> GetAllFrames() override;
mojom::WebViewClient* GetWebViewClient() override;
- mojo::ApplicationImpl* app_;
+ mojo::Shell* shell_;
mojom::WebViewClientPtr client_;
mojo::StrongBinding<WebView> binding_;
mus::Window* root_;
« no previous file with comments | « components/web_view/web_view_apptest.cc ('k') | components/web_view/web_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698