Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: components/web_view/web_view_apptest.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/web_view/web_view_application_delegate.cc ('k') | components/web_view/web_view_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/web_view/web_view_apptest.cc
diff --git a/components/web_view/web_view_apptest.cc b/components/web_view/web_view_apptest.cc
index 1b144308c51b1b193c433e81cb63f6b9569f977f..475141d818469a9726ac9728dbd67258e2ef15ea 100644
--- a/components/web_view/web_view_apptest.cc
+++ b/components/web_view/web_view_apptest.cc
@@ -97,9 +97,10 @@ class WebViewTest : public mus::WindowServerTestBase,
}
// Overridden from ApplicationDelegate:
- void Initialize(mojo::ApplicationImpl* app) override {
- WindowServerTestBase::Initialize(app);
- app_ = app;
+ void Initialize(mojo::Shell* shell, const std::string& url,
+ uint32_t id) override {
+ WindowServerTestBase::Initialize(shell, url, id);
+ shell_ = shell;
}
// Overridden from WindowTreeDelegate:
@@ -109,7 +110,7 @@ class WebViewTest : public mus::WindowServerTestBase,
root->AddChild(content_);
content_->SetVisible(true);
- web_view_.Init(app_, content_);
+ web_view_.Init(shell_, content_);
WindowServerTestBase::OnEmbed(root);
}
@@ -152,7 +153,7 @@ class WebViewTest : public mus::WindowServerTestBase,
QuitNestedRunLoop();
}
- mojo::ApplicationImpl* app_;
+ mojo::Shell* shell_;
mus::Window* content_;
« no previous file with comments | « components/web_view/web_view_application_delegate.cc ('k') | components/web_view/web_view_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698