Replace GrGLInterface's function pointers with std::functions

Replace GrGLInterface's function pointers with std::functions.

This is to facilitate binding to GLES2Interface in Chromium rather than the C interface. It requires capturing the GLES2Interface.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1674823002

Committed: https://skia.googlesource.com/skia/+/9f2dc27642e7e556f54f632bf6eff195d8cf52e1

[bsalomon, 2016-02-05 21:25:09]

Description was changed from

==========
Use # Enter a description of the change.
Use std::function to for OpenGL calls
==========

to

==========
Use # Enter a description of the change.
Use std::function to for OpenGL calls
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-02-06 22:31:56]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-06 22:32:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1674823002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1674823002/80001

[bsalomon, 2016-02-06 22:33:56]

Description was changed from

==========
Use # Enter a description of the change.
Use std::function to for OpenGL calls
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Replace GrGLInterface's function pointers with std::functions.

This is to facilitate binding to GLES2Interface in Chromium rather than the C
interface. It requires capturing the GLES2Interface.
==========

[commit-bot: I haz the power, 2016-02-06 22:57:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-06 22:57:22]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-02-06 23:09:50]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2016-02-06 23:09:51]

Companion CL is https://codereview.chromium.org/1671283002/

[robertphillips, 2016-02-08 13:13:16]

lgtm

https://codereview.chromium.org/1674823002/diff/80001/include/private/SkTLogic.h
File include/private/SkTLogic.h (right):

https://codereview.chromium.org/1674823002/diff/80001/include/private/SkTLogi...
include/private/SkTLogic.h:33: template <typename T> using remove_cv_t =
typename std::remove_cv<T>::type;
remove the new spaces ?

[bsalomon, 2016-02-08 14:52:34]

Description was changed from

==========
Replace GrGLInterface's function pointers with std::functions.

This is to facilitate binding to GLES2Interface in Chromium rather than the C
interface. It requires capturing the GLES2Interface.
==========

to

==========
Replace GrGLInterface's function pointers with std::functions.

This is to facilitate binding to GLES2Interface in Chromium rather than the C
interface. It requires capturing the GLES2Interface.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-02-08 14:52:48]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-02-08 14:52:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1674823002/#ps100001
(title: "rebase and address comment")

[bsalomon, 2016-02-08 14:52:55]

https://codereview.chromium.org/1674823002/diff/80001/include/private/SkTLogic.h
File include/private/SkTLogic.h (right):

https://codereview.chromium.org/1674823002/diff/80001/include/private/SkTLogi...
include/private/SkTLogic.h:33: template <typename T> using remove_cv_t =
typename std::remove_cv<T>::type;
On 2016/02/08 13:13:16, robertphillips wrote:
> remove the new spaces ?

Done.

[commit-bot: I haz the power, 2016-02-08 14:52:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1674823002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1674823002/100001

[commit-bot: I haz the power, 2016-02-08 15:22:20]

Description was changed from

==========
Replace GrGLInterface's function pointers with std::functions.

This is to facilitate binding to GLES2Interface in Chromium rather than the C
interface. It requires capturing the GLES2Interface.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Replace GrGLInterface's function pointers with std::functions.

This is to facilitate binding to GLES2Interface in Chromium rather than the C
interface. It requires capturing the GLES2Interface.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/9f2dc27642e7e556f54f632bf6eff195d8cf52e1
==========

[commit-bot: I haz the power, 2016-02-08 15:22:21]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/9f2dc27642e7e556f54f632bf6eff195d8cf52e1

[bungeman-skia, 2016-02-08 20:22:51]

bungeman@google.com changed reviewers:
+ bungeman@google.com

[bungeman-skia, 2016-02-08 20:22:52]

Is this causing the Windows roll failures?

https://codereview.chromium.org/1674823002/diff/100001/include/gpu/gl/GrGLFun...
File include/gpu/gl/GrGLFunctions.h (right):

https://codereview.chromium.org/1674823002/diff/100001/include/gpu/gl/GrGLFun...
include/gpu/gl/GrGLFunctions.h:14: #include "../private/SkTLogic.h"
I imagine this include was added in order to replace
std::remove_pointer<GLPTR>::type with skstd::remove_pointer_t<GLPTR>. However
that didn't seem to happen, so either this include should be removed or the code
below changed. As things stand, it would be better to just directly include
<type_traits>.

[bsalomon, 2016-02-09 15:21:38]

https://codereview.chromium.org/1674823002/diff/100001/include/gpu/gl/GrGLFun...
File include/gpu/gl/GrGLFunctions.h (right):

https://codereview.chromium.org/1674823002/diff/100001/include/gpu/gl/GrGLFun...
include/gpu/gl/GrGLFunctions.h:14: #include "../private/SkTLogic.h"
On 2016/02/08 20:22:52, bungeman1 wrote:
> I imagine this include was added in order to replace
> std::remove_pointer<GLPTR>::type with skstd::remove_pointer_t<GLPTR>. However
> that didn't seem to happen, so either this include should be removed or the
code
> below changed. As things stand, it would be better to just directly include
> <type_traits>.

Oops, I did that change locally and then never uploaded it. Will submit it as a
separate change.