Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/gpu/gl/GrGLCaps.cpp

Issue 1674823002: Replace GrGLInterface's function pointers with std::functions (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase and address comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 8
9 #include "GrGLCaps.h" 9 #include "GrGLCaps.h"
10 10
(...skipping 646 matching lines...) Expand 10 before | Expand all | Expand 10 after
657 if (!hasChromiumPathRendering && 657 if (!hasChromiumPathRendering &&
658 ctxInfo.version() < GR_GL_VER(3, 1)) { 658 ctxInfo.version() < GR_GL_VER(3, 1)) {
659 return false; 659 return false;
660 } 660 }
661 } 661 }
662 // We only support v1.3+ of GL_NV_path_rendering which allows us to 662 // We only support v1.3+ of GL_NV_path_rendering which allows us to
663 // set individual fragment inputs with ProgramPathFragmentInputGen. The API 663 // set individual fragment inputs with ProgramPathFragmentInputGen. The API
664 // additions are detected by checking the existence of the function. 664 // additions are detected by checking the existence of the function.
665 // We also use *Then* functions that not all drivers might have. Check 665 // We also use *Then* functions that not all drivers might have. Check
666 // them for consistency. 666 // them for consistency.
667 if (nullptr == gli->fFunctions.fStencilThenCoverFillPath || 667 if (!gli->fFunctions.fStencilThenCoverFillPath ||
668 nullptr == gli->fFunctions.fStencilThenCoverStrokePath || 668 !gli->fFunctions.fStencilThenCoverStrokePath ||
669 nullptr == gli->fFunctions.fStencilThenCoverFillPathInstanced || 669 !gli->fFunctions.fStencilThenCoverFillPathInstanced ||
670 nullptr == gli->fFunctions.fStencilThenCoverStrokePathInstanced || 670 !gli->fFunctions.fStencilThenCoverStrokePathInstanced ||
671 nullptr == gli->fFunctions.fProgramPathFragmentInputGen) { 671 !gli->fFunctions.fProgramPathFragmentInputGen) {
672 return false; 672 return false;
673 } 673 }
674 return true; 674 return true;
675 } 675 }
676 676
677 bool GrGLCaps::readPixelsSupported(GrPixelConfig rtConfig, 677 bool GrGLCaps::readPixelsSupported(GrPixelConfig rtConfig,
678 GrPixelConfig readConfig, 678 GrPixelConfig readConfig,
679 std::function<void (GrGLenum, GrGLint*)> getI ntegerv, 679 std::function<void (GrGLenum, GrGLint*)> getI ntegerv,
680 std::function<bool ()> bindRenderTarget) cons t { 680 std::function<bool ()> bindRenderTarget) cons t {
681 // If it's not possible to even have a render target of rtConfig then read p ixels is 681 // If it's not possible to even have a render target of rtConfig then read p ixels is
(...skipping 977 matching lines...) Expand 10 before | Expand all | Expand 10 after
1659 for (int j = 0; j < kExternalFormatUsageCnt; ++j) { 1659 for (int j = 0; j < kExternalFormatUsageCnt; ++j) {
1660 SkASSERT(defaultEntry.fFormats.fExternalFormat[j] != 1660 SkASSERT(defaultEntry.fFormats.fExternalFormat[j] !=
1661 fConfigTable[i].fFormats.fExternalFormat[j]); 1661 fConfigTable[i].fFormats.fExternalFormat[j]);
1662 } 1662 }
1663 SkASSERT(defaultEntry.fFormats.fExternalType != fConfigTable[i].fFormats .fExternalType); 1663 SkASSERT(defaultEntry.fFormats.fExternalType != fConfigTable[i].fFormats .fExternalType);
1664 } 1664 }
1665 #endif 1665 #endif
1666 } 1666 }
1667 1667
1668 void GrGLCaps::onApplyOptionsOverrides(const GrContextOptions& options) {} 1668 void GrGLCaps::onApplyOptionsOverrides(const GrContextOptions& options) {}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698