Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1674753002: Disable fullscreen video in OverlayPanels (Closed)

Created:
4 years, 10 months ago by mdjones
Modified:
4 years, 10 months ago
Reviewers:
wychen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable fullscreen video in OverlayPanels This change hides the fullscreen button for videos in Reader Mode and uses an empty implementation of ContentVideoViewEmbedder in case it is somehow triggered. This is a temporary measure until a proper fullscreen handler can be implemented. BUG=581943 Committed: https://crrev.com/e735266dd5b07c7b094ed06f17db167f36a4b143 Cr-Commit-Position: refs/heads/master@{#374830}

Patch Set 1 #

Patch Set 2 : add todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java View 1 3 chunks +23 lines, -0 lines 0 comments Download
M components/dom_distiller/core/css/distilledpage.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mdjones
This is to prevent crashes until we have a proper fullscreen video solution. PTAL
4 years, 10 months ago (2016-02-05 18:07:53 UTC) #2
wychen
lgtm
4 years, 10 months ago (2016-02-10 19:46:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674753002/20001
4 years, 10 months ago (2016-02-11 00:36:16 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-11 01:43:27 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:33:54 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e735266dd5b07c7b094ed06f17db167f36a4b143
Cr-Commit-Position: refs/heads/master@{#374830}

Powered by Google App Engine
This is Rietveld 408576698