Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

Issue 1674753002: Disable fullscreen video in OverlayPanels (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add todo Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/dom_distiller/core/css/distilledpage.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
index 2fddd228afa4344095d46688581c5a0a504a5bcc..a97aa08cbb29998f9831d15a791f2557c11de2ff 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
@@ -6,6 +6,7 @@ package org.chromium.chrome.browser.compositor.bottombar;
import android.app.Activity;
import android.content.Context;
+import android.view.View;
import android.view.View.MeasureSpec;
import org.chromium.base.ActivityState;
@@ -17,6 +18,7 @@ import org.chromium.chrome.browser.compositor.bottombar.OverlayPanelManager.Pane
import org.chromium.chrome.browser.compositor.layouts.LayoutUpdateHost;
import org.chromium.chrome.browser.compositor.scene_layer.SceneLayer;
import org.chromium.chrome.browser.tab.Tab;
+import org.chromium.content.browser.ContentVideoViewEmbedder;
import org.chromium.content.browser.ContentViewClient;
import org.chromium.content.browser.ContentViewCore;
import org.chromium.content_public.common.TopControlsState;
@@ -334,6 +336,27 @@ public class OverlayPanel extends OverlayPanelAnimation implements ActivityState
MeasureSpec.EXACTLY);
}
}
+
+ @Override
+ public ContentVideoViewEmbedder getContentVideoViewEmbedder() {
+ // TODO(mdjones): Possibly enable fullscreen video in overlay panels rather than
+ // passing an empty implementation.
+ return new ContentVideoViewEmbedder() {
+ @Override
+ public void enterFullscreenVideo(View view) {}
+
+ @Override
+ public void exitFullscreenVideo() {}
+
+ @Override
+ public View getVideoLoadingProgressView() {
+ return null;
+ }
+
+ @Override
+ public void setSystemUiVisibility(boolean enterFullscreen) {}
+ };
+ }
});
return content;
« no previous file with comments | « no previous file | components/dom_distiller/core/css/distilledpage.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698