Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1674433002: Revert of ScreenWin Testability and Restructuring (Closed)

Created:
4 years, 10 months ago by robliao
Modified:
4 years, 10 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, scottmg, brucedawson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ScreenWin Testability and Restructuring (patchset #9 id:280001 of https://codereview.chromium.org/1639623003/ ) Reason for revert: std::vector<const T> wasn't intended to be possible by the C++ standard and does not work in VS2015. Original issue's description: > ScreenWin Testability and Restructuring > > To allow easier testing of ScreenWin, this CL restructures ScreenWin to allow > override of system OS calls through virtual methods as well as override the > available displays available in the system. > > This CL also adds support to hold system pixel display rects that will be > used by multi-DPI aware scaling coming in a later CL. > > BUG=426656 > > Committed: https://crrev.com/663b48643605198c21bfb8b8f81968223833021f > Cr-Commit-Position: refs/heads/master@{#373582} TBR=oshima@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=426656 Committed: https://crrev.com/a59d0ad2829f5099af70e17e2d3c4749c1ea6cad Cr-Commit-Position: refs/heads/master@{#373650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -991 lines) Patch
M ui/gfx/BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download
M ui/gfx/display.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/gfx/gfx.gyp View 3 chunks +0 lines, -5 lines 0 comments Download
M ui/gfx/screen_win.h View 3 chunks +11 lines, -48 lines 0 comments Download
M ui/gfx/screen_win.cc View 5 chunks +115 lines, -142 lines 0 comments Download
M ui/gfx/screen_win_unittest.cc View 2 chunks +20 lines, -593 lines 0 comments Download
D ui/gfx/test/display_util.h View 1 chunk +0 lines, -23 lines 0 comments Download
M ui/gfx/test/gfx_util.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D ui/gfx/win/display_info.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ui/gfx/win/display_info.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D ui/gfx/win/screen_win_display.h View 1 chunk +0 lines, -31 lines 0 comments Download
D ui/gfx/win/screen_win_display.cc View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
robliao
Created Revert of ScreenWin Testability and Restructuring
4 years, 10 months ago (2016-02-04 23:01:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674433002/1
4 years, 10 months ago (2016-02-04 23:04:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 23:09:37 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 23:11:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a59d0ad2829f5099af70e17e2d3c4749c1ea6cad
Cr-Commit-Position: refs/heads/master@{#373650}

Powered by Google App Engine
This is Rietveld 408576698