Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 167443003: Oilpan: reduce visibility of Visitor::trace(const RawPtr<T>&). (Closed)

Created:
6 years, 10 months ago by sof
Modified:
6 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: reduce visibility of Visitor::trace(const RawPtr<T>&). With Oilpan enabled, fail earlier and make it a compile-time error to attempt to trace a RawPtr<>. (Previously it would only trigger an assert at run-time.) With Oilpan disabled, the method is needed to compile tracing methods over RawPtr-using transition types. R= BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M Source/heap/Visitor.h View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sof
Please take a look. As suggested in https://codereview.chromium.org/139803012/diff/660001/Source/heap/Visitor.h#newcode330
6 years, 10 months ago (2014-02-16 19:44:08 UTC) #1
haraken
LGTM
6 years, 10 months ago (2014-02-17 00:50:20 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 10 months ago (2014-02-17 00:50:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/167443003/1
6 years, 10 months ago (2014-02-17 00:50:31 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-17 03:52:09 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=12675
6 years, 10 months ago (2014-02-17 03:52:09 UTC) #6
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 10 months ago (2014-02-17 04:27:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/167443003/1
6 years, 10 months ago (2014-02-17 04:27:42 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-17 06:23:54 UTC) #9
Message was sent while issue was closed.
Change committed as 167267

Powered by Google App Engine
This is Rietveld 408576698