Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Unified Diff: Source/heap/Visitor.h

Issue 167443003: Oilpan: reduce visibility of Visitor::trace(const RawPtr<T>&). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/heap/Visitor.h
diff --git a/Source/heap/Visitor.h b/Source/heap/Visitor.h
index 0dc62ab25c9f1f65954d087c797272b87e0e0eff..80623bf29531b79daa213ccdecb17877dff4bd6d 100644
--- a/Source/heap/Visitor.h
+++ b/Source/heap/Visitor.h
@@ -319,17 +319,15 @@ public:
#endif
}
+#if !ENABLE(OILPAN)
// Similarly, this trace method is to trace a RawPtrWillBeMember
// when ENABLE(OILPAN) is not enabled.
// Remove this once we remove RawPtrWillBeMember.
template<typename T>
void trace(const RawPtr<T>&)
{
-#if ENABLE(OILPAN)
- // RawPtrs should never be traced.
- ASSERT_NOT_REACHED();
-#endif
}
+#endif
// This method marks an object and adds it to the set of objects
// that should have their trace method called. Since not all
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698