Issue 1674173003: Carefully handle large end time values in AudioParam automations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1674173003: Carefully handle large end time values in AudioParam automations (Closed)

Created:
4 years, 10 months ago by Raymond Toy

Modified:
4 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2623

Target Ref:
refs/pending/branch-heads/2623

Project:
chromium

Visibility:
Public.

Carefully handle large end time values in AudioParam automations The computation of fillToEndFrame invokes undefined behavior when casting a huge value to a size_t when the value doesn't fit in a size_t. BUG=582701 TEST=audioparam-large-endtime.html Review URL: https://codereview.chromium.org/1657593003 Cr-Commit-Position: refs/heads/master@{#373003} (cherry picked from commit 559fdab922a8d82f82824657e6b211d8c778bf60) Committed: https://chromium.googlesource.com/chromium/src/+/6ed62c4558ecf70351097ed7d7de9367cf7b40de

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -1 line)			Patch
A	third_party/WebKit/LayoutTests/webaudio/audioparam-large-endtime.html	View	1 chunk	+75 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/webaudio/audioparam-large-endtime-expected.txt	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp	View	1 chunk	+8 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Raymond Toy

4 years, 10 months ago (2016-02-08 20:05:55 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6ed62c4558ecf70351097ed7d7de9367cf7b40de.