Carefully handle large end time values in AudioParam automations

Carefully handle large end time values in AudioParam automations

The computation of fillToEndFrame invokes undefined behavior when
casting a huge value to a size_t when the value doesn't fit in a
size_t.

BUG=582701
TEST=audioparam-large-endtime.html

Committed: https://crrev.com/559fdab922a8d82f82824657e6b211d8c778bf60
Cr-Commit-Position: refs/heads/master@{#373003}

[Raymond Toy, 2016-02-01 19:23:46]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2016-02-01 19:23:47]

PTAL

[hongchan, 2016-02-02 17:07:43]

https://codereview.chromium.org/1657593003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/audioparam-large-endtime.html
(right):

https://codereview.chromium.org/1657593003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/audioparam-large-endtime.html:23: // See
crbug.com/582701.  Create an audioparam with a huge end time and verify that to
The URL does not exist. Typo?

https://codereview.chromium.org/1657593003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/audioparam-large-endtime.html:26: //
Test linear ramp with huge end time
This test only covers linear and expo. Do we need to test setTarget as well? Or
it is safe from this bug?

[Raymond Toy, 2016-02-02 17:34:47]

https://codereview.chromium.org/1657593003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/audioparam-large-endtime.html
(right):

https://codereview.chromium.org/1657593003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/audioparam-large-endtime.html:23: // See
crbug.com/582701.  Create an audioparam with a huge end time and verify that to
On 2016/02/02 17:07:42, hoch wrote:
> The URL does not exist. Typo?

It works for me.

https://codereview.chromium.org/1657593003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/audioparam-large-endtime.html:26: //
Test linear ramp with huge end time
On 2016/02/02 17:07:42, hoch wrote:
> This test only covers linear and expo. Do we need to test setTarget as well?
Or
> it is safe from this bug?

I just wanted to fix the immediate issue.  I filed
https://code.google.com/p/chromium/issues/detail?id=583045 to fix all the other
possible cases.

[hongchan, 2016-02-02 17:54:38]

On 2016/02/02 17:34:47, Raymond Toy wrote:
>
https://codereview.chromium.org/1657593003/diff/20001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/webaudio/audioparam-large-endtime.html
> (right):
> 
>
https://codereview.chromium.org/1657593003/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/webaudio/audioparam-large-endtime.html:23: //
See
> crbug.com/582701.  Create an audioparam with a huge end time and verify that
to
> On 2016/02/02 17:07:42, hoch wrote:
> > The URL does not exist. Typo?
> 
> It works for me.
> 
>
https://codereview.chromium.org/1657593003/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/webaudio/audioparam-large-endtime.html:26: //
> Test linear ramp with huge end time
> On 2016/02/02 17:07:42, hoch wrote:
> > This test only covers linear and expo. Do we need to test setTarget as well?
> Or
> > it is safe from this bug?
> 
> I just wanted to fix the immediate issue.  I filed
> https://code.google.com/p/chromium/issues/detail?id=583045 to fix all the
other
> possible cases.

Is there any way to tie this CL or the issue above to the issue 583045? Seems
like 583045 is a meta bug and the others are blocking issues. Right?

[hongchan, 2016-02-02 17:54:48]

lgtm

[Raymond Toy, 2016-02-02 17:57:15]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2016-02-02 17:57:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1657593003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1657593003/20001

[commit-bot: I haz the power, 2016-02-02 19:27:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-02 19:28:18]

Description was changed from

==========
Carefully handle large end time values in AudioParam automations

The computation of fillToEndFrame invokes undefined behavior when
casting a huge value to a size_t when the value doesn't fit in a
size_t.

BUG=582701
TEST=audioparam-large-endtime.html
==========

to

==========
Carefully handle large end time values in AudioParam automations

The computation of fillToEndFrame invokes undefined behavior when
casting a huge value to a size_t when the value doesn't fit in a
size_t.

BUG=582701
TEST=audioparam-large-endtime.html

Committed: https://crrev.com/559fdab922a8d82f82824657e6b211d8c778bf60
Cr-Commit-Position: refs/heads/master@{#373003}
==========

[commit-bot: I haz the power, 2016-02-02 19:28:20]

Patchset 2 (id:??) landed as
https://crrev.com/559fdab922a8d82f82824657e6b211d8c778bf60
Cr-Commit-Position: refs/heads/master@{#373003}