Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 1674113002: Conditionally define PersistentNode destructor. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Conditionally define PersistentNode destructor. R= BUG= Committed: https://crrev.com/8d2f9cece991004dd64b857db936032573a7aca0 Cr-Commit-Position: refs/heads/master@{#374093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/platform/heap/PersistentNode.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look. i expect compiler optimizations to take care of this no-op already ...
4 years, 10 months ago (2016-02-08 06:18:15 UTC) #2
haraken
LGTM
4 years, 10 months ago (2016-02-08 06:20:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1674113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1674113002/1
4 years, 10 months ago (2016-02-08 06:38:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 07:22:09 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 07:23:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d2f9cece991004dd64b857db936032573a7aca0
Cr-Commit-Position: refs/heads/master@{#374093}

Powered by Google App Engine
This is Rietveld 408576698