Add UnlinkedConst.isValid and set it during summarizing.

Add UnlinkedConst.isValid and set it during summarizing.

Several final fields in SDK have not valid constant expression
initializers, which is OK because the enclosing classes don't have
constant constructors. However we were throwing exceptions and failing
building SDK summaries.

Alternatively we could just ignore final field initializers in classes
without a constant constructor. But it seems to me that we need to
catch exceptions anyway, just in case of invalid code.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/0a3b938409c2f29868defbf8f71b8dd3043a976d

[Paul Berry, 2016-02-08 15:02:23]

Are you intending to modify the resynthesis code in a future CL?  Or are no
resynthesis changes needed?

If no resynthesis changes are needed then I don't understand why this CL is
necessary (why store information in the summary that won't be used?)

https://codereview.chromium.org/1674073002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/1674073002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:522: bool get isValid;
Change this to `isInvalid`.  That way in the normal (valid) case it won't
consume any bytes in the summary file.

[scheglov, 2016-02-08 17:01:42]

PTAL

Yes, resynthesizer will be updated in another CL.

https://codereview.chromium.org/1674073002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/1674073002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:522: bool get isValid;
On 2016/02/08 15:02:23, Paul Berry wrote:
> Change this to `isInvalid`.  That way in the normal (valid) case it won't
> consume any bytes in the summary file.

Done.

[Paul Berry, 2016-02-08 17:07:41]

lgtm

https://codereview.chromium.org/1674073002/diff/20001/pkg/analyzer/lib/src/su...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/1674073002/diff/20001/pkg/analyzer/lib/src/su...
pkg/analyzer/lib/src/summary/idl.dart:1288: * that it is a valid , check
[UnlinkedConst.isValid].
Missing a word here.  I think you mean: "...that it is a valid constant; check
[UnlinkedConst.isInvalid]."

https://codereview.chromium.org/1674073002/diff/20001/pkg/analyzer/lib/src/su...
pkg/analyzer/lib/src/summary/idl.dart:1623: * does not mean that it is a valid,
check [UnlinkedConst.isValid].
Similar comment here.

[scheglov, 2016-02-08 17:11:14]

Description was changed from

==========
Add UnlinkedConst.isValid and set it during summarizing.

Several final fields in SDK have not valid constant expression
initializers, which is OK because the enclosing classes don't have
constant constructors. However we were throwing exceptions and failing
building SDK summaries.

Alternatively we could just ignore final field initializers in classes
without a constant constructor. But it seems to me that we need to
catch exceptions anyway, just in case of invalid code.

R=paulberry@google.com
BUG=
==========

to

==========
Add UnlinkedConst.isValid and set it during summarizing.

Several final fields in SDK have not valid constant expression
initializers, which is OK because the enclosing classes don't have
constant constructors. However we were throwing exceptions and failing
building SDK summaries.

Alternatively we could just ignore final field initializers in classes
without a constant constructor. But it seems to me that we need to
catch exceptions anyway, just in case of invalid code.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/0a3b938409c2f29868defbf8f71b8dd3043a976d
==========

[scheglov, 2016-02-08 17:11:16]

Committed patchset #2 (id:20001) manually as
0a3b938409c2f29868defbf8f71b8dd3043a976d (presubmit successful).