Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: pkg/analyzer/lib/src/summary/summarize_elements.dart

Issue 1674073002: Add UnlinkedConst.isValid and set it during summarizing. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Generate the 'isInvalid' property. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/summary/summarize_elements.dart
diff --git a/pkg/analyzer/lib/src/summary/summarize_elements.dart b/pkg/analyzer/lib/src/summary/summarize_elements.dart
index 05a8da72052d51d34309ad9e509c2d0fc9b84bb7..4f7a12ae6224c849339a32f55bb35d16a79e0014 100644
--- a/pkg/analyzer/lib/src/summary/summarize_elements.dart
+++ b/pkg/analyzer/lib/src/summary/summarize_elements.dart
@@ -966,6 +966,11 @@ class _ConstExprSerializer extends AbstractConstExprSerializer {
_ConstExprSerializer(this.serializer, this.constructorParameterNames);
@override
+ bool isConstructorParameterName(String name) {
+ return constructorParameterNames?.contains(name) ?? false;
+ }
+
+ @override
void serializeAnnotation(Annotation annotation) {
if (annotation.arguments == null) {
assert(annotation.constructorName == null);
@@ -1017,7 +1022,9 @@ class _ConstExprSerializer extends AbstractConstExprSerializer {
if (identifier is PrefixedIdentifier &&
element is PropertyAccessorElement &&
!element.isStatic) {
- assert(element.name == 'length');
+ if (element.name != 'length') {
+ throw new StateError('Only "length" property is allowed in constants.');
+ }
Element prefixElement = identifier.prefix.staticElement;
int prefixRef = serializer._getElementReferenceId(prefixElement);
int lengthRef = serializer._getLengthPropertyReference(prefixRef);
@@ -1051,11 +1058,6 @@ class _ConstExprSerializer extends AbstractConstExprSerializer {
DartType type = typeName != null ? typeName.type : DynamicTypeImpl.instance;
return serializer.serializeTypeRef(type, null);
}
-
- @override
- bool isConstructorParameterName(String name) {
- return constructorParameterNames?.contains(name) ?? false;
- }
}
/**

Powered by Google App Engine
This is Rietveld 408576698